8000 Advice about bootstrap file is not up to date · Issue #7357 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

Advice about bootstrap file is not up to date #7357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
garak opened this issue Jan 13, 2017 · 4 comments
Closed

Advice about bootstrap file is not up to date #7357

garak opened this issue Jan 13, 2017 · 4 comments
Labels
actionable Clear and specific issues ready for anyone to take them. bug good first issue Ideal for your first contribution! (some Symfony experience may be required) Status: Needs Review

Comments

@garak
Copy link
Contributor
garak commented Jan 13, 2017

This part of the docs http://symfony.com/doc/master/performance.html#use-bootstrap-files looks not up to date with latest changes made in this PR symfony/symfony-standard#1030
@xabbuh xabbuh added actionable Clear and specific issues ready for anyone to take them. bug good first issue Ideal for your first contribution! (some Symfony experience may be required) labels Jan 13, 2017
@teohhanhui
Copy link
Contributor
teohhanhui commented Mar 20, 2017 •
edited
Loading

I think the docs can also recommend removing https://github.com/symfony/symfony-standard/blob/v3.2.6/composer.json#L35 when using PHP >= 7.0, say, with this in composer.json:

{
    ...
    "require": {
        "php": ">=7.0.0",
        ...
    }
    ...
}

The related code blocks could also be removed from both app.php and app_dev.php.

@ahocquard ahocquard mentioned this issue Aug 2, 2017
Merged
@ghost
Copy link
ghost commented Dec 1, 2017

Current issue status:

  • Present in 2.7 (Requires PHP >=5.3.9). Advise: keep it.
  • Present in 2.8 (Requires PHP >=5.3.9). Advise: keep it.
  • Present in 3.0, 3.1 and 3.2 but are not maintained versions.
  • Not present in 3.3 (Requires PHP ^5.5.9|>=7.0.8). Advise: add note about version lower than PHP 7.
  • Not present in 3.4 (Requires PHP ^5.5.9|>=7.0.8). Advise: add note about version lower than PHP 7.
  • Not present in 4.0 (Requires PHP ^7.1.3). Advise: don't change or add anything.

ping: @weaverryan @xabbuh @javiereguiluz

@xabbuh
Copy link
Member
xabbuh commented Dec 1, 2017

If I am not completely mistaken, we had changes during the last half year which more or less ignored legacy PHP versions like 5.3 and so on. To me, we could just bring the docs for 2.7 and 2.8 in line with the Symfony 3 docs.

@javiereguiluz
Copy link
Member

Closing as fixed. 2.8 and 3.4 include the "bootstrap" section but with a big warning about PHP 7. Starting from 4.0, the "bootstrap" section no longer exists. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
actionable Clear and specific issues ready for anyone to take them. bug good first issue Ideal for your first contribution! (some Symfony experience may be required) Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@javiereguiluz @garak @teohhanhui @xabbuh @carsonbot
0