fix FormError access in Twig template #9631
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
| @@ -155,7 +155,7 @@ so that the severity is added as an additional HTML class: | |||
| {%- if errors|length > 0 -%} | |||
| <ul> | |||
| {%- for error in errors -%} | |||
| <li class="{{ error.constraint.payload.severity ?? '' }}">{{ error.message }}</li> | |||
| <li class="{{ error.cause.constraint.payload.severity ?? '' }}">{{ error.message }}</li> | |||
There was a problem hiding this comment.
Are we sure about this? I recently merged a pull request that removed cause in this code 😕 Is this cause something that Symfony adds on its own? Thanks!
There was a problem hiding this comment.
That's how the FormError class looks like: https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Form/FormError.php
I also commented on said PR: #9581 (comment)
There was a problem hiding this comment.
I'm sorry for having merged the previous one without reviewing it more in detail. Let's merge your fix right now. Thanks!
javiereguiluz
added a commit
that referenced
this pull request
Apr 23, 2018
This PR was merged into the 2.7 branch. Discussion ---------- fix FormError access in Twig template Commits ------- 140e4f4 fix FormError access in Twig template
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.