8000 fix FormError access in Twig template by xabbuh · Pull Request #9631 · symfony/symfony-docs · GitHub
[go: up one dir, main page]

Skip to content

fix FormError access in Twig template #9631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 23, 2018
Merged

Conversation

xabbuh
Copy link
Member
@xabbuh xabbuh commented Apr 20, 2018

No description provided.

@xabbuh xabbuh added this to the 2.7 milestone Apr 20, 2018
@xabbuh xabbuh mentioned this pull request Apr 20, 2018
@@ -155,7 +155,7 @@ so that the severity is added as an additional HTML class:
{%- if errors|length > 0 -%}
<ul>
{%- for error in errors -%}
<li class="{{ error.constraint.payload.severity ?? '' }}">{{ error.message }}</li>
<li class="{{ error.cause.constraint.payload.severity ?? '' }}">{{ error.message }}</li>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we sure about this? I recently merged a pull request that removed cause in this code 😕 Is this cause something that Symfony adds on its own? Thanks!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's how the FormError class looks like: https://github.com/symfony/symfony/blob/master/src/Symfony/Component/Form/FormError.php

I also commented on said PR: #9581 (comment)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry for having merged the previous one without reviewing it more in detail. Let's merge your fix right now. Thanks!

@javiereguiluz javiereguiluz merged commit 140e4f4 into symfony:2.7 Apr 23, 2018
javiereguiluz added a commit that referenced this pull request Apr 23, 2018
This PR was merged into the 2.7 branch.

Discussion
----------

fix FormError access in Twig template

Commits
-------

140e4f4 fix FormError access in Twig template
@xabbuh xabbuh deleted the pr-9581 branch April 23, 2018 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0