-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Fix "payload" usage #9581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix "payload" usage #9581
Conversation
Nice catch! We merged it on 2.7 branch. Thanks. |
This PR was submitted for the 3.4 branch but it was merged into the 2.7 branch instead (closes #9581). Discussion ---------- Fix "payload" usage <!-- If your pull request fixes a BUG, use the oldest maintained branch that contains the bug (see https://symfony.com/roadmap for the list of maintained branches). If your pull request documents a NEW FEATURE, use the same Symfony branch where the feature was introduced (and `master` for features of unreleased versions). --> Commits ------- f69f68f Fix "payload" usage
@@ -155,8 +155,8 @@ so that the severity is added as an additional HTML class: | |||
{%- if errors|length > 0 -%} | |||
<ul> | |||
{%- for error in errors -%} | |||
{% if error.cause.constraint.payload.severity is defined %} | |||
{% set severity = error.cause.constraint.payload.severity %} | |||
{% if error.constraint.payload.severity is defined %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like the wrong fix to me. The previous paragraph is talking about the form_errors
block. Thus, we can assume that errors is an array of FormErrror
instances where there is no $constraint
property, but indeed a $cause
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see #9631
No description provided.