8000 Mentioned the new FirewallConfig class by javiereguiluz · Pull Request #9207 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

Mentioned the new FirewallConfig class #9207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Mentioned the new FirewallConfig class #9207

wants to merge 1 commit into from

Conversation

javiereguiluz
Copy link
Member
@javiereguiluz javiereguiluz commented Feb 5, 2018 •
edited
Loading

This fixes #7164.

@chalasr it'd be great to add some example ... but I don't know how to do that. Could you please help me? Thanks!

@javiereguiluz javiereguiluz added this to the 3.4 milestone Feb 5, 2018
@chalasr
Copy link
Member
chalasr commented Feb 15, 2018

@javiereguiluz Thanks for the PR, I totally forgot about this.
As mentioned in the fixed ticket, use cases for getting firewall information are not common, right now I fail at finding a concrete, legit example for userland code. It can be useful to third party libraries needing to introspect the security layer behind an HTTP request, I don't think such examples should be added to the docs.
Could we just show how to get the firewall name for the current request without providing a real life example?

@javiereguiluz
Copy link
Member Author

@chalasr thanks for reviewing. Let's do as you propose. Should we change anything in the current PR to better show the example code ... or is it enough as it is?

chalasr
chalasr approved these changes Feb 16, 2018
View reviewed changes
Copy link
Member
@chalasr chalasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine for me 👍

javiereguiluz added a commit that referenced this pull request Feb 16, 2018
@javiereguiluz
minor #9207 Mentioned the new FirewallConfig class (javiereguiluz)
33550f5 
This PR was merged into the 3.4 branch.

Discussion
----------

Mentioned the new FirewallConfig class

This fixes #7164.

@chalasr it'd be great to add some example ... but I don't know how to do that. Could you please help me? Thanks!

Commits
-------

6f4469c Mentioned the new FirewallConfig class
@javiereguiluz javiereguiluz mentioned this pull request Feb 16, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chalasr chalasr chalasr approved these changes

Assignees
No one assigned
Labels
Security Status: Reviewed
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.
3 participants
@javiereguiluz @chalasr @carsonbot
0