8000 Add docs for the Firewall Config class · Issue #7164 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

Add docs for the Firewall Config class #7164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
javiereguiluz opened this issue Nov 25, 2016 · 4 comments
Closed

Add docs for the Firewall Config class #7164

javiereguiluz opened this issue Nov 25, 2016 · 4 comments
Labels
hasPR A Pull Request has already been submitted for this issue. Security
Milestone
3.2

Comments

@javiereguiluz
Copy link
Member

symfony/symfony#19398 introduced a FirewallConfig class accessible from FirewallContext. Should we document it or at leas mention it?
@javiereguiluz javiereguiluz added this to the 3.2 milestone Nov 25, 2016
@ogizanagi
Copy link
Contributor

Use cases for accessing the firewall configs are probably too limited right now, so I don't think it worth documenting it. Your blog post is probably perfect and enough for mentioning this feature.

Plus, if more use cases are discovered, we may rework some parts (see symfony/symfony#20591) which will expose a different entrypoint.

cc @chalasr

@chalasr
Copy link
Member
chalasr commented Nov 25, 2016 •
edited
Loading

@ogizanagi is right about that use cases are limited but I would say it's still good to have in the documentation because of the considerable number of existing support questions and issues for which a small mention about this feature would have been useful:

Even if it's just about documenting what is actually possible to do on this subject so it would be clear what is not, and give the right way to do (especially since using the security token providerKey is neither always available nor always accurate).

Maybe we could start by adding a small mention in the bundle documentation and make it grows as we improve the feature (I feel it could be useful to add some more informations about the registered listeners for instance, but let's wait for concrete use cases).

If nobody pick it I can give it a try asap

@javiereguiluz
Copy link
Member Author

@chalasr documenting this won't be easy for me. If you want to give a try, I can help you later polishing the docs if needed. Thanks!

@javiereguiluz javiereguiluz added the hasPR A Pull Request has already been submitted for this issue. label Feb 5, 2018
@javiereguiluz javiereguiluz mentioned this issue Feb 5, 2018
Closed
javiereguiluz added a commit that referenced this issue Feb 16, 2018
@javiereguiluz
minor #9207 Mentioned the new FirewallConfig class (javiereguiluz)
33550f5 
This PR was merged into the 3.4 branch.

Discussion
----------

Mentioned the new FirewallConfig class

This fixes #7164.

@chalasr it'd be great to add some example ... but I don't know how to do that. Could you please help me? Thanks!

Commits
-------

6f4469c Mentioned the new FirewallConfig class
@javiereguiluz
Copy link
Member Author

Fixed by #9207.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
hasPR A Pull Request has already been submitted for this issue. Security
Projects
None yet
Milestone
3.2
Development

No branches or pull requests
3 participants
@javiereguiluz @ogizanagi @chalasr
0