[Validator] Html5 Email Validation #8487
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabpot
added a commit
to symfony/symfony
that referenced
this pull request
Dec 11, 2017
This PR was merged into the 4.1-dev branch. Discussion ---------- [Validator] Html5 Email Validation Currently we only support a very loose validation. There is now a standard HTML5 element with matching regex. This will add the ability to set a `mode` on the email validator. The mode will change the validation that is applied to the field as a whole. These modes are: * loose: The pattern from previous Symfony versions (default) * strict: Strictly matching the RFC * html5: The regex used for the HTML5 Element Deprecates the `strict=true` parameter in favour of `mode='strict'` | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | #21531 | License | MIT | Doc PR | symfony/symfony-docs#8487 <!-- - Bug fixes must be submitted against the lowest branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against the 3.4, legacy code removals go to the master branch. - Please fill in this template according to the PR you're about to submit. - Replace this comment by a description of what your PR is solving. --> Commits ------- cf04108 [Validator] Html5 Email Validation
Contributor
Author
|
I've rebased this off master, as eventually the PR went into the 4.1 branch (which is currently master). I'd love get this reviewed now that that's merged in. |
xabbuh
reviewed
Dec 12, 2017
xabbuh
reviewed
Dec 12, 2017
xabbuh
reviewed
Dec 12, 2017
xabbuh
approved these changes
Dec 12, 2017
Member
There was a problem hiding this comment.
This looks great. I have just left a few minor comments. Thanks for creating the feature and writing the documentation for it.
Add documentation about the new mode parameter. Adds descriptions for the 'loose', 'strict', and 'html5' options.
Member
|
Thank you @PurpleBooth. |
xabbuh
added a commit
that referenced
this pull request
Dec 22, 2017
This PR was merged into the master branch. Discussion ---------- [Validator] Html5 Email Validation Add documentation about the new mode parameter. Adds descriptions for the 'loose', 'strict', and 'html5' options. Relates to symfony/symfony#24442 Commits ------- 07d4bf9 [Validator] Html5 Email Validation
| | Applies to | :ref:`property or method <validation-property-target>` | | ||
| +----------------+---------------------------------------------------------------------+ | ||
| | Options | - `strict`_ | | ||
| | Options | - `mode`_ | |
Contributor
There was a problem hiding this comment.
Shouldn't the strict option have been annotated as "deprecated in Symfony 4.1" rather than completely replaced?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add documentation about the new mode parameter. Adds descriptions for
the 'loose', 'strict', and 'html5' options.
Relates to symfony/symfony#24442