8000 Update filesystem.rst by flip111 · Pull Request #8323 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

Update filesystem.rst #8323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Update filesystem.rst #8323

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9f3f1f0
Update filesystem.rst
flip111 Aug 30, 2017
c63dae9
Update filesystem.rst
flip111 Aug 31, 2017
1d70c8b
Update filesystem.rst
flip111 Aug 31, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions components/filesystem.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,10 @@ On POSIX filesystems, directories are created with a default mode value

This function ignores already existing directories.

.. note::

The directory permissions are affected by the current `umask<https://en.wikipedia.org/wiki/Umask/>`_.. Set the umask for your webserver, use PHP's `umask() function<https://secure.php.net/umask>`_. or use the chmod() function after the directory has been created.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are few things to change here, but overall this looks good. Can you update the paragraph to something like this:

.. note::

    The directory permissions are affected by the current `umask`_. Set
    the umask for your webserver, use PHP's :phpfunction:`umask` function
    or use the :phpfunction:`chmod` function after the directory has been
    created.

You then need to add the link target at the end of the document:

.. _`umask`: https://en.wikipedia.org/wiki/Umask


exists
~~~~~~

Expand Down
0