Update filesystem.rst #8323
Closed
Update filesystem.rst #8323
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add information about umask to directory creation
|
Don't know what wrong with the build was following http://docutils.sourceforge.net/docs/ref/rst/restructuredtext.html#embedded-uris-and-aliases |
xabbuh
reviewed
Aug 31, 2017
components/filesystem.rst
Outdated
| @@ -68,6 +68,10 @@ On POSIX filesystems, directories are created with a default mode value | |||
|
|
|||
| This function ignores already existing directories. | |||
|
|
|||
| .. note:: | |||
|
|
|||
| The directory permissions are affected by the current `umask<https://en.wikipedia.org/wiki/Umask/>`_.. Set the umask for your webserver, use PHP's `umask() function<https://secure.php.net/umask>`_. or use the chmod() function after the directory has been created. | |||
There was a problem hiding this comment.
There are few things to change here, but overall this looks good. Can you update the paragraph to something like this:
.. note::
The directory permissions are affected by the current `umask`_. Set
the umask for your webserver, use PHP's :phpfunction:`umask` function
or use the :phpfunction:`chmod` function after the directory has been
created.You then need to add the link target at the end of the document:
.. _`umask`: https://en.wikipedia.org/wiki/Umask
javiereguiluz
approved these changes
Aug 31, 2017
fixed links
xabbuh
reviewed
Aug 31, 2017
components/filesystem.rst
Outdated
| @@ -68,6 +68,10 @@ On POSIX filesystems, directories are created with a default mode value | |||
|
|
|||
| This function ignores already existing directories. | |||
|
|
|||
| .. note:: | |||
|
|
|||
| The directory permissions are affected by the current `umask`_. Set the umask for your webserver, use PHP's :phpfunction:`umask` function or use the :phpfunction:`chmod` function after the directory has been created. | |||
There was a problem hiding this comment.
Please also wrap all lines after the first word that crosses the 72nd character.
Added line wrap at char 72
|
Thank you @flip111. |
xabbuh
added a commit
that referenced
this pull request
Sep 1, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add information about umask to directory creation