8000 Simplified the requirements article by javiereguiluz · Pull Request #8142 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

Simplified the requirements article #8142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Simplified the requirements article #8142

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fcfb1bc
Simplified the requirements article
javiereguiluz Jul 10, 2017
d82d842
Added a note about removing the config.php file when you no longer ne…
javiereguiluz Jul 10, 2017
bc3c633
Minor fixes
javiereguiluz Jul 12, 2017
74b63f4
Reworded some contents
javiereguiluz Jul 13, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Added a note about removing the config.php file when you no longer ne… 
…ed it
  • Loading branch information
@javiereguiluz
javiereguiluz committed Jul 10, 2017
commit d82d84231e88de35226d812b5e221022a78d59e0
3 changes: 3 additions & 0 deletions reference/requirements.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,9 @@ Browse the ``web/config.php`` file in your browser and fix the reported issues.
When using the PHP built-in web server, this file is available at
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just spotted this one: talking about the built-in web server here IMO does not make sense. The built-in web server is started using the same configuration that is used when running the CLI check below. So that's just doing work twice. What is actually important is that you perform the check using your "real" web server setup (so most likely Nginx or Apache).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are so right! I'm sorry about this mistake. I've removed this and reworded other parts. Thanks!

``http://127.0.0.1:8000/config.php``

Once you've fixed all the reported issues, delete this ``web/config.php`` file
to avoid leaking internal information about your application to visitors.

Checking Requirements for the Command Console
---------------------------------------------

Expand Down
0