Simplified the requirements article #8142
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xabbuh
reviewed
Jul 11, 2017
reference/requirements.rst
Outdated
| Required | ||
| -------- | ||
| Beware that PHP can define a different configuration for the command console and | ||
| the web server, so you need to check requirements in both. |
xabbuh
approved these changes
Jul 11, 2017
xabbuh
reviewed
Jul 12, 2017
reference/requirements.rst
Outdated
|
|
||
| .. caution:: | ||
| Browse the ``web/config.php`` file in your browser and fix the reported issues. | ||
| When using the PHP built-in web server, this file is available at |
There was a problem hiding this comment.
Just spotted this one: talking about the built-in web server here IMO does not make sense. The built-in web server is started using the same configuration that is used when running the CLI check below. So that's just doing work twice. What is actually important is that you perform the check using your "real" web server setup (so most likely Nginx or Apache).
There was a problem hiding this comment.
You are so right! I'm sorry about this mistake. I've removed this and reworded other parts. Thanks!
This was referenced Jul 20, 2017
|
Thank you @javiereguiluz. |
xabbuh
added a commit
that referenced
this pull request
Jul 20, 2017
This PR was squashed before being merged into the 2.7 branch (closes #8142). Discussion ---------- Simplified the requirements article Explaining the full list of requirements is not very smart, because we have a Requirement Checker that does that and it's hard to keep the doc in sync with that tool. I propose to simplify this article to only mention the specific PHP version required by Symfony and then explain how to check the other requirements. If you agree with this, I'll make the PRs for the other maintained Symfony versions. If this is merged, we can then simplify the installation article even more (removing this section: "Checking Symfony Requirements" -> https://github.com/symfony/symfony-docs/pull/8135/files#diff-1ef3833b924d9500d8baaa4bfa9fdb68R84) Commits ------- 05c8b06 Simplified the requirements article
xabbuh
added a commit
that referenced
this pull request
Jul 20, 2017
xabbuh
added a commit
that referenced
this pull request
Jul 20, 2017
xabbuh
added a commit
that referenced
this pull request
Jul 20, 2017
xabbuh
added a commit
that referenced
this pull request
Jul 20, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explaining the full list of requirements is not very smart, because we have a Requirement Checker that does that and it's hard to keep the doc in sync with that tool.
I propose to simplify this article to only mention the specific PHP version required by Symfony and then explain how to check the other requirements.
If you agree with this, I'll make the PRs for the other maintained Symfony versions. If this is merged, we can then simplify the installation article even more (removing this section: "Checking Symfony Requirements" -> https://github.com/symfony/symfony-docs/pull/8135/files#diff-1ef3833b924d9500d8baaa4bfa9fdb68R84)