8000 [Console] Reword a subheading of console/logging.rst by javiereguiluz · Pull Request #7275 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

[Console] Reword a subheading of console/logging.rst #7275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[Console] Reword a subheading of console/logging.rst #7275

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7b7bca3
[Console] Reword a subheading of console/logging.rst
javiereguiluz Dec 18, 2016
53e6a97
Minor improvements
javiereguiluz Dec 21, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
[Console] Reword a subheading of console/logging.rst
  • Loading branch information
@javiereguiluz
javiereguiluz committed Dec 18, 2016
commit 7b7bca3559044744c06dbcf6cb3488b3ee03e9e4
7 changes: 4 additions & 3 deletions console/logging.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,12 +167,13 @@ service configuration. Your method receives a
:class:`Symfony\\Component\\Console\\Event\\ConsoleExceptionEvent` object,
which has methods to get information about the event and the exception.

Logging non-0 Exit Statuses
Logging Error Exit Statuses
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add a label for the old headline to maintain existing anchors?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

---------------------------

The logging capabilities of the console can be further extended by logging
non-0 exit statuses. This way you will know if a command had any errors, even
if no exceptions were thrown.
commands that return error exist statuses, which are any number different than
9D86
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"error exist statuses" sounds weird. Can we reword it a bit?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original text should have been "... exit ..." instead of "... exist ..." Would that be better?

zero. This way you will know if a command had any errors, even if no exceptions
were thrown.

First configure a listener for console terminate events in the service container:

Expand Down
0