[Console] Reword a subheading of console/logging.rst #7275
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xabbuh
reviewed
Dec 19, 2016
| --------------------------- | ||
|
|
||
| The logging capabilities of the console can be further extended by logging | ||
| non-0 exit statuses. This way you will know if a command had any errors, even | ||
| if no exceptions were thrown. | ||
| commands that return error exist statuses, which are any number different than |
There was a problem hiding this comment.
"error exist statuses" sounds weird. Can we reword it a bit?
There was a problem hiding this comment.
The original text should have been "... exit ..." instead of "... exist ..." Would that be better?
| @@ -167,12 +167,13 @@ service configuration. Your method receives a | |||
| :class:`Symfony\\Component\\Console\\Event\\ConsoleExceptionEvent` object, | |||
| which has methods to get information about the event and the exception. | |||
|
|
|||
| Logging non-0 Exit Statuses | |||
| Logging Error Exit Statuses | |||
There was a problem hiding this comment.
Can you please add a label for the old headline to maintain existing anchors?
|
👍 Status: Reviewed |
|
Thank you Javier. |
xabbuh
added a commit
that referenced
this pull request
Dec 25, 2016
…iereguiluz) This PR was squashed before being merged into the 2.7 branch (closes #7275). Discussion ---------- [Console] Reword a subheading of console/logging.rst Because of the typography we use, the "non-0 exit statuses" heading reads as "nono exit statuses" (instead of "non-zero ..."):  I propose a minor reword to avoid this problem. Commits ------- b1ec1f0 [Console] Reword a subheading of console/logging.rst
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of the typography we use, the "non-0 exit statuses" heading reads as "nono exit statuses" (instead of "non-zero ..."):
I propose a minor reword to avoid this problem.