Clarify Process::wait() callback behaviour #7099
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was no clear description of when the Process::wait() callback was triggered and it seemed like it would be called once the process was complete which is incorrect.
wouterj
approved these changes
Nov 1, 2016
|
|
||
| $process->wait(); | ||
|
|
||
| // do things after the process has finished |
There was a problem hiding this comment.
Please change this to // ... do things after the process has finished
| @@ -130,9 +130,26 @@ are done doing other stuff:: | |||
|
|
|||
| $process = new Process('ls -lsa'); | |||
| $process->start(); | |||
|
|
|||
There was a problem hiding this comment.
please remove this added trailing whitespace
|
👍 Thanks a lot, seems a lot clearer to me. I've commented 2 minor changes. If you have time, you can fix them, otherwise we'll do it during the merge. status: reviewed |
Also removed unintended extra whitespace
|
Great, thanks. I've made the requested changes now. |
xabbuh
added a commit
that referenced
this pull request
Nov 5, 2016
This PR was submitted for the 3.1 branch but it was merged into the 2.7 branch instead (closes #7099). Discussion ---------- Clarify Process::wait() callback behaviour There was no clear description of when the Process::wait() callback was triggered and it seemed like it would be called once the process was complete which is incorrect. I lost several hours after misunderstanding how this works and then trying to figure out why my 'after process' code was being triggered before the process had finished. Hopefully this change makes it clearer. Commits ------- d696a15 Clarify Process::wait() callback behaviour
xabbuh
added a commit
that referenced
this pull request
Nov 5, 2016
|
Thank you @Lilchef. |
xabbuh
added a commit
that referenced
this pull request
Nov 5, 2016
* 2.7: [#6961] add additional config formats [#7104] minor typo fix Fixed minor syntax issues and typos more precision on class name, and lazy service add warning about the limitation on using swiftmail with file spool and lazy loading Removed the proposed note and updated the title Added note on ODM id notation being different [#7099] remove trailing whitespaces Clarify Process::wait() callback behaviour Minor text fix - wrong submit button label (Forms) [Doctrine] Slave/Master configuration options Fix broken link Fix typo Add missing parenthesis for methods and a few minor tweaks [Doctrine] Exception note about functions with named managers
xabbuh
added a commit
that referenced
this pull request
Nov 5, 2016
* 2.8: [#6961] add additional config formats [#7104] minor typo fix Fixed minor syntax issues and typos more precision on class name, and lazy service add warning about the limitation on using swiftmail with file spool and lazy loading Removed the proposed note and updated the title Added note on ODM id notation being different [#7099] remove trailing whitespaces Clarify Process::wait() callback behaviour Minor text fix - wrong submit button label (Forms) [Doctrine] Slave/Master configuration options Fix broken link Fix typo Add missing parenthesis for methods and a few minor tweaks [Doctrine] Exception note about functions with named managers
xabbuh
added a commit
that referenced
this pull request
Nov 5, 2016
* 3.1: [#6961] add additional config formats [#7104] minor typo fix Fixed minor syntax issues and typos more precision on class name, and lazy service add warning about the limitation on using swiftmail with file spool and lazy loading Removed the proposed note and updated the title Added note on ODM id notation being different [#7099] remove trailing whitespaces Clarify Process::wait() callback behaviour Remove AssetsHelper from the templating component Minor text fix - wrong submit button label (Forms) [Doctrine] Slave/Master configuration options Fix broken link Fix typo Add missing parenthesis for methods and a few minor tweaks Update input.rst [Profiler] Fix rst typo [Doctrine] Exception note about functions with named managers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was no clear description of when the Process::wait() callback was triggered and it seemed like it would be called once the process was complete which is incorrect.
I lost several hours after misunderstanding how this works and then trying to figure out why my 'after process' code was being triggered before the process had finished. Hopefully this change makes it clearer.