8000 [Doctrine] Exception note about functions with named managers by rvanlaak · Pull Request #6961 · symfony/symfony-docs · GitHub
[go: up one dir, main page]

Skip to content

[Doctrine] Exception note about functions with named managers #6961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 5, 2016

Conversation

rvanlaak
Copy link
Contributor

In case the managers were defined/named explicitly, the DQL functions should also be defined over there.

Copy link
Member
@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Status: reviewed

@@ -69,4 +69,23 @@ In Symfony, you can register your custom DQL functions as follows:
),
));

.. note::

In case the `entity_managers` were named explicitly, configuring the functions with the
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use double backticks for the code, as it's required by the RST format.


In case the `entity_managers` were named explicitly, configuring the functions with the
orm directly will trigger the exception `Unrecognized option "dql" under "doctrine.orm"`.
The `dql` configuration block should be nested under the entity manager.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be nested -> must be defined

under the entity manager. -> under the appropriate entity manager. ? under the specific entity manager. ? under the named entity manager. ?

In case the managers were defined explicitly, the dql functions should also be defined over there.
@rvanlaak
Copy link
Contributor Author

Thanks @javiereguiluz , I've processed your feedback and amended the commit.

# Place your functions here
dql:
datetime_functions:
test_datetime: AppBundle\DQL\DatetimeFunction
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rvanlaak Can you also add the config for the XML and PHP formats like we do it usually?

@xabbuh xabbuh merged commit 075f56c into symfony:2.7 Nov 5, 2016
xabbuh added a commit that referenced this pull request Nov 5, 2016
…gers (rvanlaak)

This PR was merged into the 2.7 branch.

Discussion
----------

[Doctrine] Exception note about functions with named managers

In case the managers were defined/named explicitly, the DQL functions should also be defined over there.

Commits
-------

075f56c [Doctrine] Exception note about functions with named managers
xabbuh added a commit that referenced this pull request Nov 5, 2016
@xabbuh
Copy link
Member
xabbuh commented Nov 5, 2016

Thank you @rvanlaak for this nice improvement. I have merged it and added the additional config formats in 5f004c3.

xabbuh added a commit that referenced this pull request Nov 5, 2016
* 2.7:
  [#6961] add additional config formats
  [#7104] minor typo fix
  Fixed minor syntax issues and typos
  more precision on class name, and lazy service
  add warning about the limitation on using swiftmail with file spool and lazy loading
  Removed the proposed note and updated the title
  Added note on ODM id notation being different
  [#7099] remove trailing whitespaces
  Clarify Process::wait() callback behaviour
  Minor text fix - wrong submit button label (Forms)
  [Doctrine] Slave/Master configuration options
  Fix broken link
  Fix typo
  Add missing parenthesis for methods and a few minor tweaks
  [Doctrine] Exception note about functions with named managers
xabbuh added a commit that referenced this pull request Nov 5, 2016
* 2.8:
  [#6961] add additional config formats
  [#7104] minor typo fix
  Fixed minor syntax issues and typos
  more precision on class name, and lazy service
  add warning about the limitation on using swiftmail with file spool and lazy loading
  Removed the proposed note and updated the title
  Added note on ODM id notation being different
  [#7099] remove trailing whitespaces
  Clarify Process::wait() callback behaviour
  Minor text fix - wrong submit button label (Forms)
  [Doctrine] Slave/Master configuration options
  Fix broken link
  Fix typo
  Add missing parenthesis for methods and a few minor tweaks
  [Doctrine] Exception note about functions with named managers
xabbuh added a commit that referenced this pull request Nov 5, 2016
* 3.1:
  [#6961] add additional config formats
  [#7104] minor typo fix
  Fixed minor syntax issues and typos
  more precision on class name, and lazy service
  add warning about the limitation on using swiftmail with file spool and lazy loading
  Removed the proposed note and updated the title
  Added note on ODM id notation being different
  [#7099] remove trailing whitespaces
  Clarify Process::wait() callback behaviour
  Remove AssetsHelper from the templating component
  Minor text fix - wrong submit button label (Forms)
  [Doctrine] Slave/Master configuration options
  Fix broken link
  Fix typo
  Add missing parenthesis for methods and a few minor tweaks
  Update input.rst
  [Profiler] Fix rst typo
  [Doctrine] Exception note about functions with named managers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
0