[Doctrine] Exception note about functions with named managers #6961
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javiereguiluz
approved these changes
Sep 14, 2016
| @@ -69,4 +69,23 @@ In Symfony, you can register your custom DQL functions as follows: | |||
| ), | |||
| )); | |||
|
|
|||
| .. note:: | |||
|
|
|||
| In case the `entity_managers` were named explicitly, configuring the functions with the | |||
There was a problem hiding this comment.
Please use double backticks for the code, as it's required by the RST format.
|
|
||
| In case the `entity_managers` were named explicitly, configuring the functions with the | ||
| orm directly will trigger the exception `Unrecognized option "dql" under "doctrine.orm"`. | ||
| The `dql` configuration block should be nested under the entity manager. |
There was a problem hiding this comment.
should be nested -> must be defined
under the entity manager. -> under the appropriate entity manager. ? under the specific entity manager. ? under the named entity manager. ?
In case the managers were defined explicitly, the dql functions should also be defined over there.
|
Thanks @javiereguiluz , I've processed your feedback and amended the commit. |
xabbuh
reviewed
Oct 26, 2016
| # Place your functions here | ||
| dql: | ||
| datetime_functions: | ||
| test_datetime: AppBundle\DQL\DatetimeFunction |
There was a problem hiding this comment.
@rvanlaak Can you also add the config for the XML and PHP formats like we do it usually?
xabbuh
added a commit
that referenced
this pull request
Nov 5, 2016
…gers (rvanlaak) This PR was merged into the 2.7 branch. Discussion ---------- [Doctrine] Exception note about functions with named managers In case the managers were defined/named explicitly, the DQL functions should also be defined over there. Commits ------- 075f56c [Doctrine] Exception note about functions with named managers
xabbuh
added a commit
that referenced
this pull request
Nov 5, 2016
xabbuh
added a commit
that referenced
this pull request
Nov 5, 2016
* 2.7: [#6961] add additional config formats [#7104] minor typo fix Fixed minor syntax issues and typos more precision on class name, and lazy service add warning about the limitation on using swiftmail with file spool and lazy loading Removed the proposed note and updated the title Added note on ODM id notation being different [#7099] remove trailing whitespaces Clarify Process::wait() callback behaviour Minor text fix - wrong submit button label (Forms) [Doctrine] Slave/Master configuration options Fix broken link Fix typo Add missing parenthesis for methods and a few minor tweaks [Doctrine] Exception note about functions with named managers
xabbuh
added a commit
that referenced
this pull request
Nov 5, 2016
* 2.8: [#6961] add additional config formats [#7104] minor typo fix Fixed minor syntax issues and typos more precision on class name, and lazy service add warning about the limitation on using swiftmail with file spool and lazy loading Removed the proposed note and updated the title Added note on ODM id notation being different [#7099] remove trailing whitespaces Clarify Process::wait() callback behaviour Minor text fix - wrong submit button label (Forms) [Doctrine] Slave/Master configuration options Fix broken link Fix typo Add missing parenthesis for methods and a few minor tweaks [Doctrine] Exception note about functions with named managers
xabbuh
added a commit
that referenced
this pull request
Nov 5, 2016
* 3.1: [#6961] add additional config formats [#7104] minor typo fix Fixed minor syntax issues and typos more precision on class name, and lazy service add warning about the limitation on using swiftmail with file spool and lazy loading Removed the proposed note and updated the title Added note on ODM id notation being different [#7099] remove trailing whitespaces Clarify Process::wait() callback behaviour Remove AssetsHelper from the templating component Minor text fix - wrong submit button label (Forms) [Doctrine] Slave/Master configuration options Fix broken link Fix typo Add missing parenthesis for methods and a few minor tweaks Update input.rst [Profiler] Fix rst typo [Doctrine] Exception note about functions with named managers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
377F
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case the managers were defined/named explicitly, the DQL functions should also be defined over there.