8000 Removing php opening tags by Deamon · Pull Request #5960 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

Removing php opening tags #5960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Removing php opening tags #5960

wants to merge 3 commits into from

Conversation

Deamon
Copy link
Contributor
@Deamon Deamon commented Dec 5, 2015
Q A
Doc fix? yes
New docs? no
Applies to >2.3
Fixed tickets #5937

Douglas Naphas and others added 3 commits November 30, 2015 14:57
@weaverryan
[symfony#5875] Fixed link description, list of common media types
5eca563
@weaverryan
minor symfony#5931 [symfony#5875] Fixed link description, list of com…
523d08c 
…mon media types (Douglas Naphas)

This PR was submitted for the 2.7 branch but it was merged into the 2.3 branch instead (closes symfony#5931).

Discussion
----------

[symfony#5875] Fixed link description, list of common media types

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | 2.7+
| Fixed tickets | symfony#5875

Commits
-------

5eca563 [symfony#5875] Fixed link description, list of common media types
@Deamon
removing php opening tags
dd8809b
@Deamon
Copy link
Contributor Author
Deamon commented Dec 5, 2015

Well thanks to the crap connection, it did not take the good branch for the PR.
I wanted to merge to 2.3 branch.
I only change the book/from_flat_php_to_symfony2.rst file.
How ca I change this?

@wouterj
Copy link
Member
wouterj commented Dec 5, 2015

@Deamon by closing this PR and opening a new one. Anyway, the merge tool can take care of this as well if I remember correctly.

@Deamon
Copy link
8120 Contributor Author
Deamon commented Dec 5, 2015

@wouterj, that's what they(speaker at the hackday) told us this morning.
Let me know if I have to close and reopen with good params.

@Deamon Deamon closed this Dec 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Deamon @wouterj @weaverryan
0