8000 [documentation] Php header missing in an example code · Issue #5937 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

[documentation] Php header missing in an example code #5937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ottoshmidt opened this issue Nov 30, 2015 · 2 comments
Closed

[documentation] Php header missing in an example code #5937

ottoshmidt opened this issue Nov 30, 2015 · 2 comments
Labels
actionable Clear and specific issues ready for anyone to take them. good first issue Ideal for your first contribution! (some Symfony experience may be required) hasPR A Pull Request has already been submitted for this issue.

Comments

@ottoshmidt
Copy link

An example code for controllers.php from chapter Symfony versus Flat PHP (http://symfony.com/doc/current/book/from_flat_php_to_symfony2.html#add-a-touch-of-symfony) should contain <?php
header somewhere at the top (Listing 2-17 in the pdf book, p. 21).
@xabbuh
Copy link
Member
xabbuh commented Dec 1, 2015

Thank you for reporting this @ottoshmidt.

Actually, I am not sure if we weren't better off with removing the opening tags in this chapter too like we do in all other parts of the documentation. Imho it doesn't add much value but only causes confusion if we mix different styles.

@wouterj
Copy link
Member
wouterj commented Dec 5, 2015

👍 for removing all opening tags.

@wouterj wouterj added good first issue Ideal for your first contribution! (some Symfony experience may be required) actionable Clear and specific issues ready for anyone to take them. and removed needs comments labels Dec 5, 2015
Deamon added a commit to Deamon/symfony-docs that referenced this issue Dec 5, 2015
@Deamon
refs symfony#5937, removing php opening tags
1dd34a7
This was referenced Dec 5, 2015
Closed
Merged
@xabbuh xabbuh added the hasPR A Pull Request has already been submitted for this issue. label Dec 8, 2015
xabbuh added a commit that referenced this issue Dec 13, 2015
@xabbuh
minor #5965 Removing php opening tags (Deamon)
e9760b2 
This PR was merged into the 2.3 branch.

Discussion
----------

Removing php opening tags

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | >2.3
| Fixed tickets | #5937

Commits
-------

dd8809b removing php opening tags
@xabbuh xabbuh closed this as completed Dec 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
actionable Clear and specific issues ready for anyone to take them. good first issue Ideal for your first contribution! (some Symfony experience may be required) hasPR A Pull Request has already been submitted for this issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ottoshmidt @wouterj @xabbuh
2AE8
0