10000 Added page "Community Reviews" by webmozart · Pull Request #5480 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content
8000

Added page "Community Reviews" #5480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from
Closed

Added page "Community Reviews" #5480

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
b91191a
Added initial draft of "Community Reviews" page
webmozart Jul 1, 2015
65a5a94
Added link to PRs in need of review
webmozart Jul 1, 2015
899c782
Improved sample comment
webmozart Jul 1, 2015
d08ccf8
Fixed case
webmozart Jul 1, 2015
2d7622b
Fixed numbering
webmozart Jul 2, 2015
62a4e85
Wording
webmozart Jul 2, 2015
d13a03b
Integrated PR comments
webmozart Jul 20, 2015
0b5ce44
Added instructions about testing a PR
webmozart Aug 27, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Added link to PRs in need of review
  • Loading branch information
@webmozart
webmozart committed Jul 1, 2015
commit 65a5a9453cc59c7a9ed70577b2b8c481f7e16a5a
7 changes: 4 additions & 3 deletions contributing/community/reviews.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ The Bug Report Review Process
-----------------------------

A good way to get started with reviewing is to pick a bug report from the
`bug reports in need of review queue`_.
`bug reports in need of review`_.

The steps for the review are:

Expand Down Expand Up @@ -103,7 +103,7 @@ out whether the implementation is complete.
It is okay to do partial reviews. If you do a partial review, post how far you
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/post/comment

got and leave the PR in "Needs Review" state.

The steps for the review are:
Pick a pull request from the `PRs in need of review`_ and follow these steps:

1. **Is the PR Complete**?

Expand Down Expand Up @@ -183,7 +183,8 @@ The steps for the review are:
.. _Symfony Standard Edition: https://github.com/symfony/symfony-standard
.. _create a GitHub account: https://help.github.com/articles/signing-up-for-a-new-github-account/
.. _forking: https://help.github.com/articles/fork-a-repo/
.. _bug reports in need of review queue: https://github.com/symfony/symfony/issues?utf8=%E2%9C%93&q=is%3Aopen+is%3Aissue+label%3A%22Bug%22+label%3A%22Status%3A+Needs+Review%22+
.. _bug reports in need of review: https://github.com/symfony/symfony/issues?utf8=%E2%9C%93&q=is%3Aopen+is%3Aissue+label%3A%22Bug%22+label%3A%22Status%3A+Needs+Review%22+
.. _PRs in need of review: https://github.com/symfony/symfony/issues?utf8=%E2%9C%93&q=is%3Aopen+is%3Apr+label%3A%22Status%3A+Needs+Review%22+
.. _Contribution Guidelines: https://github.com/symfony/symfony/blob/master/CONTRIBUTING.md
.. _Symfony's Release Schedule: http://symfony.com/doc/current/contributing/community/releases.html#schedule
.. _Symfony Roadmap: https://symfony.com/roadmap
0