8000 Added page "Community Reviews" by webmozart · Pull Request #5480 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

Added page "Community Reviews" #5480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from
Closed

Added page "Community Reviews" #5480

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
b91191a
Added initial draft of "Community Reviews" page
webmozart Jul 1, 2015
65a5a94
Added link to PRs in need of review
webmozart Jul 1, 2015
899c782
Improved sample comment
webmozart Jul 1, 2015
d08ccf8
Fixed case
webmozart Jul 1, 2015
2d7622b
Fixed numbering
webmozart Jul 2, 2015
62a4e85
Wording
webmozart Jul 2, 2015
d13a03b
Integrated PR comments
webmozart Jul 20, 2015
0b5ce44
Added instructions about testing a PR
webmozart Aug 27, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Added instructions about testing a PR
  • Loading branch information
@webmozart
webmozart committed Aug 27, 2015
commit 0b5ce44c099eb665ad1e1a6ef72b988171b93a27
10 changes: 9 additions & 1 deletion contributing/community/reviews.rst
View file 8000
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,8 +154,16 @@ Pick a pull request from the `PRs in need of review`_ and follow these steps:
#. **Test the Code**

Take your project from step 3 and test whether the PR works properly.
Replace the Symfony vendor by the code in the PR by running the following Git
commands. Insert the PR ID for the ``<ID>`` placeholders:

TODO: precise steps
.. code-block:: text

$ cd vendor/symfony/symfony
$ git fetch origin pull/<ID>/head:pr<ID>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it really called origin? Afaik, Composer calls its repository composer

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, just checked and origin is available (besides composer).

$ git checkout pr<ID>

Now you can test the project against the code in the PR.

#. **Update the PR Status**

Expand Down
0