10000 [Best Practices] readd mistakenly removed label by xabbuh · Pull Request #4607 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

[Best Practices] readd m 8000 istakenly removed label #4607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 11, 2014
Merged

[Best Practices] readd mistakenly removed label #4607

merged 1 commit into from
Dec 11, 2014

Conversation

xabbuh
Copy link
Member
@xabbuh xabbuh commented Dec 7, 2014
Q A
Doc fix? yes
New docs? no
Applies to all
Fixed tickets

The button was mistakenly removed in c090a74.

@xabbuh xabbuh mentioned this pull request Dec 7, 2014
Merged
@xabbuh
Copy link
Member Author
xabbuh commented Dec 9, 2014

@weaverryan @wouterj Can we merge this? Otherwise, all pull requests based on the 2.3 branch will continue to fail.

@wouterj
Copy link
Member
wouterj commented Dec 11, 2014

Thanks Christian! I'm sorry for the delay. When working on a PR, I can't merge PRs until I commit changes...

@wouterj wouterj merged commit eabcc59 into symfony:2.3 Dec 11, 2014
wouterj added a commit that referenced this pull request Dec 11, 2014
@wouterj
minor #4607 [Best Practices] readd mistakenly removed label (xabbuh)
8b006bb 
This PR was merged into the 2.3 branch.

Discussion
----------

[Best Practices] readd mistakenly removed label

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | all
| Fixed tickets |

The button was mistakenly removed in c090a74.

Commits
-------

eabcc59 readd mistakenly removed label
@xabbuh xabbuh deleted the fix-build-error branch December 11, 2014 12:51
@stof
9EC6 Copy link
Member
stof commented Dec 11, 2014

@wouterj git stash is your friend (or git commit -m 'WIP' and the git commit --amend when working on the change again to finish it)

@wouterj
Copy link
Member
wouterj commented Dec 11, 2014

@stof yeah, just learned stash from @xabbuh. It looks pretty great :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xabbuh @wouterj @stof
0