8000 Remove ExpressionLanguage reference for 2.3 version by dangarzon · Pull Request #4548 · symfony/symfony-docs · GitHub
[go: up one dir, main page]

Skip to content

Remove ExpressionLanguage reference for 2.3 version #4548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 7, 2014

Conversation

dangarzon
Copy link
Contributor
Q A
Doc fix? yes
New docs? no
Applies to 2.3 only
Fixed tickets

Remove "Using Expressions for Complex Security Restrictions" section using ExpressionLanguage in 2.3 version.

ExpressionLanguage is a 2.4 feature.

Remove "Using Expressions for Complex Security Restrictions" section using ExpressionLanguage in 2.3 version.

ExpressionLanguage is a 2.4 feature.
@wouterj
Copy link
Member
wouterj commented Nov 29, 2014

I'm 👍

@javiereguiluz I would like to hear your opinion about this

@stof
Copy link
Member
stof commented Dec 6, 2014

👍 This should indeed not be documented on 2.3 given it is not usable there

@xabbuh
Copy link
Member
xabbuh commented Dec 6, 2014

We will probably need to take that this is added again into 2.5 and above after the 2.3 branch has been merged up.

@weaverryan weaverryan merged commit d1e7334 into symfony:2.3 Dec 7, 2014
weaverryan added a commit that referenced this pull request Dec 7, 2014
…zon)

This PR was merged into the 2.3 branch.

Discussion
----------

Remove ExpressionLanguage reference for 2.3 version

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | 2.3 only
| Fixed tickets |

Remove "Using Expressions for Complex Security Restrictions" section using ExpressionLanguage in 2.3 version.

ExpressionLanguage is a 2.4 feature.

Commits
-------

d1e7334 Remove ExpressionLanguage reference for 2.3 version
@weaverryan
Copy link
Member

Hey guys!

I merged this into the 2.3 branch (had a bad conflict that I fixed at sha: c090a74) and then re-added things at sha: ee44fe4

If you spot any issues, let me know!

Thanks!

@xabbuh
Copy link
Member
xabbuh commented Dec 7, 2014

Hi Ryan, looks good as far as I can see. 👍 Thank you!

@xabbuh
Copy link
Member
xabbuh commented Dec 7, 2014

@weaverryan Sorry, I didn't check carefully enough. One label needs to be added again (see #4607).

@wouterj
Copy link
Member
wouterj commented Dec 8, 2014

@weaverryan so we go with different versions of the Best Practices guide?

@weaverryan
Copy link
Member

@wouterj I know we talked about this before, and decided we didn't need it. But I don't see why we should avoid it. For example, imagine in 2.7 we think of some great new way to handle translations and we add it to the best practices. In that case, it could only live in the 2.7 best practices.

So I think we should keep them identical, except when a best practice just simply can't be done. The other alternative is to keep them identical, but have a note on features like this: Available only in Symfony 2.4 and higher.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
0