Remove ExpressionLanguage reference for 2.3 version #4548
Conversation
Remove "Using Expressions for Complex Security Restrictions" section using ExpressionLanguage in 2.3 version. ExpressionLanguage is a 2.4 feature.
|
I'm 👍 @javiereguiluz I would like to hear your opinion about this |
|
👍 This should indeed not be documented on 2.3 given it is not usable there |
|
We will probably need to take that this is added again into 2.5 and above after the 2.3 branch has been merged up. |
…zon) This PR was merged into the 2.3 branch. Discussion ---------- Remove ExpressionLanguage reference for 2.3 version | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | 2.3 only | Fixed tickets | Remove "Using Expressions for Complex Security Restrictions" section using ExpressionLanguage in 2.3 version. ExpressionLanguage is a 2.4 feature. Commits ------- d1e7334 Remove ExpressionLanguage reference for 2.3 version
|
Hi Ryan, looks good as far as I can see. 👍 Thank you! |
|
@weaverryan Sorry, I didn't check carefully enough. One label needs to be added again (see #4607). |
|
@weaverryan so we go with different versions of the Best Practices guide? |
|
@wouterj I know we talked about this before, and decided we didn't need it. But I don't see why we should avoid it. For example, imagine in 2.7 we think of some great new way to handle translations and we add it to the best practices. In that case, it could only live in the 2.7 best practices. So I think we should keep them identical, except when a best practice just simply can't be done. The other alternative is to keep them identical, but have a note on features like this: Available only in Symfony 2.4 and higher. |
Remove "Using Expressions for Complex Security Restrictions" section using ExpressionLanguage in 2.3 version.
ExpressionLanguage is a 2.4 feature.