[Workflow] Metadata dumping #18398
Merged
[Workflow] Metadata dumping #18398
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
added a commit
to symfony/symfony
that referenced
this pull request
Jun 21, 2023
…rt for `GraphvizDumper` (Louis-Proffit) This PR was merged into the 6.4 branch. Discussion ---------- [FrameworkBundle][Workflow] Add metadata dumping support for `GraphvizDumper` | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | Fix #50604 | License | MIT | Doc PR | symfony/symfony-docs#18398 Add `--with-metadata` option to `workflow:dump` command. It includes places, transitions and workflow's metadata in the dumped graph. Currently only supported for **GraphvizDumper** and **StateMachineGraphvizDumper**. When used, the `label` metadata is not included in the dumped metadata because it is already the title. This could be enlarged to all styling metadata. Commits ------- 457059d [FrameworkBundle][Workflow] Add metadata dumping support for GraphvizDumper
94noni
approved these changes
Oct 13, 2023
OskarStark
requested changes
Oct 13, 2023
Comment on lines
+78
to
+82
| The ``label`` metadata is not included in the dumped metadata, because it is used as a place's title. | ||
|
|
There was a problem hiding this comment.
Suggested change
| The ``label`` metadata is not included in the dumped metadata, because it is used as a place's title. | |
| The ``label`` metadata is not included in the dumped metadata, because it is used as a place's title. | |
| .. versionadded:: 6.3 | |
| The ``--with-metadata`` option was introduced in Symfony 6.3. |
31085bb to
3a4b436
Compare
|
Thank you Louis-Proffit and congratulations on your first contribution to the Symfony documentation 🎉 I merged my addition in f1c0f13 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs
Document metadata dumping option for workflow. The corresponding symfony PR handles only DOT dumper.