[FrameworkBundle][Workflow] Add metadata dumping support for GraphvizDumper
#50621
Conversation
|
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
78ad14f to
5a14370
Compare
3e8f6a7 to
47757b7
Compare
5ff2322 to
cad1bd5
Compare
GraphvizDumper
| @@ -248,6 +282,9 @@ protected function escape(string|bool $value): string | |||
| return \is_bool($value) ? ($value ? '1' : '0') : addslashes($value); | |||
| } | |||
|
|
|||
| /** | |||
| * @internal | |||
There was a problem hiding this comment.
Why make this internal?
There was a problem hiding this comment.
because all methods are in this class
cad1bd5 to
457059d
Compare
|
Thank you @Louis-Proffit. |
| 'graph' => [ | ||
| 'label' => $input->getOption('label'), | ||
| ], | ||
| 'label' => $input->getOption('label'), |
There was a problem hiding this comment.
Isn't this a BC break if someone uses the dumper in their own code (as they would have to change the options being passed to the dump() method)?
Add
--with-metadataoption toworkflow:dumpcommand. It includes places, transitions and workflow's metadata in the dumped graph. Currently only supported for GraphvizDumper and StateMachineGraphvizDumper.When used, the
labelmetadata is not included in the dumped metadata because it is already the title. This could be enlarged to all styling metadata.