Update framework.exceptions XML and PHP configuration examples
#17455
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a540745 to
6527016
Compare
6527016 to
246b741
Compare
framework.exceptions XML and PHP configuration examplesframework.exceptions XML and PHP configuration examples
nicolas-grekas
added a commit
to symfony/symfony
that referenced
this pull request
Dec 13, 2022
… with a config builder (MatTheCat) This PR was squashed before being merged into the 5.4 branch. Discussion ---------- [FrameworkBundle] Allow configuring `framework.exceptions` with a config builder | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #48191 | License | MIT | Doc PR | symfony/symfony-docs#17455 It seems the `framework.exceptions` definition has been wrongly configured for XML. As a result it is not possible to set its value using a config builder. This pull request adds a “right” way to configure `framework.exceptions` using XML. The old one should be deprecated for `6.3` and removed for `7.0`. [The documentation](https://symfony.com/doc/current/reference/configuration/framework.html#exceptions) is also wrong and should be fixed (ideally after this pull request is merged). Guidance is requested to add a test (current failures unrelated) 🙏 Commits ------- 57e28f6 [FrameworkBundle] Allow configuring `framework.exceptions` with a config builder
symfony-splitter
pushed a commit
to symfony/framework-bundle
that referenced
this pull request
Dec 13, 2022
… with a config builder (MatTheCat) This PR was squashed before being merged into the 5.4 branch. Discussion ---------- 8000 [FrameworkBundle] Allow configuring `framework.exceptions` with a config builder | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #48191 | License | MIT | Doc PR | symfony/symfony-docs#17455 It seems the `framework.exceptions` definition has been wrongly configured for XML. As a result it is not possible to set its value using a config builder. This pull request adds a “right” way to configure `framework.exceptions` using XML. The old one should be deprecated for `6.3` and removed for `7.0`. [The documentation](https://symfony.com/doc/current/reference/configuration/framework.html#exceptions) is also wrong and should be fixed (ideally after this pull request is merged). Guidance is requested to add a test (current failures unrelated) 🙏 Commits ------- 57e28f6bda [FrameworkBundle] Allow configuring `framework.exceptions` with a config builder
| ->status_code(422); | ||
| $framework->exception(BadRequestHttpException::class) | ||
| ->logLevel('debug') | ||
| ->statusCode(422) | ||
| ; | ||
| }; | ||
|
|
There was a problem hiding this comment.
Deprecated directive for version 6.3 is missing. Can you add it?
There was a problem hiding this comment.
Is that really necessary since the deprecated format was never documented?
There was a problem hiding this comment.
I agree, it is not necessary
mdoutreluingne
approved these changes
Jan 7, 2023
|
Thanks Mathieu. |
symfony-splitter
pushed a commit
to symfony/framework-bundle
that referenced
this pull request
Jul 28, 2023
… with a config builder (MatTheCat) This PR was squashed before being merged into the 5.4 branch. Discussion ---------- [FrameworkBundle] Allow configuring `framework.exceptions` with a config builder | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #48191 | License | MIT | Doc PR | symfony/symfony-docs#17455 It seems the `framework.exceptions` definition has been wrongly configured for XML. As a result it is not possible to set its value using a config builder. This pull request adds a “right” way to configure `framework.exceptions` using XML. The old one should be deprecated for `6.3` and removed for `7.0`. [The documentation](https://symfony.com/doc/current/reference/configuration/framework.html#exceptions) is also wrong and should be fixed (ideally after this pull request is merged). Guidance is requested to add a test (current failures unrelated) 🙏 Commits ------- 57e28f6bda [FrameworkBundle] Allow configuring `framework.exceptions` with a config builder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
symfony/symfony#48259 doc PR
Fix #17609