[FrameworkBundle] Allow configuring framework.exceptions with a config builder
#48259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e556cab to
89fd991
Compare
|
Given that the XSD and the doc were not in sync before, I indeed doubt this is widely used. But is it possible to keep some BC layer in a |
|
I’ll give it a try. I guess it would then count as a deprecation? |
|
Well, the deprecation will need to be added in 6.3, not in 5.4, as we cannot introduce deprecations in patch versions. |
3f18320 to
22d2fd1
Compare
|
Okay I managed to add a BC layer. This is all I’m not sure how to test it is now possible to configure |
22d2fd1 to
b0eda46
Compare
b0eda46 to
05ab2fb
Compare
nicolas-grekas
approved these changes
Dec 13, 2022
05ab2fb to
57e28f6
Compare
|
Thank you @MatTheCat. |
Merged
fabpot
added a commit
that referenced
this pull request
Dec 22, 2022
… tag (MatTheCat) This PR was squashed before being merged into the 6.3 branch. Discussion ---------- [FrameworkBundle] Deprecate `framework:exceptions` XML tag | Q | A | ------------- | --- | Branch? | 6.3 | Bug fix? | no | New feature? | no | Deprecations? | yes | Tickets | N/A | License | MIT | Doc PR | N/A Follow-up of #48259 Commits ------- b5eda47 [FrameworkBundle] Deprecate `framework:exceptions` XML tag
This was referenced Dec 28, 2022
Merged
Merged
Merged
OskarStark
added a commit
to symfony/symfony-docs
that referenced
this pull request
Jan 11, 2023
…examples (MatTheCat) This PR was merged into the 5.4 branch. Discussion ---------- Update `framework.exceptions` XML and PHP configuration examples symfony/symfony#48259 doc PR Fix #17609 Commits ------- 246b741 Update `framework.exceptions` XML and PHP configuration examples
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems the
framework.exceptionsdefinition has been wrongly configured for XML. As a result it is not possible to set its value using a config builder.This pull request adds a “right” way to configure
framework.exceptionsusing XML. The old one should be deprecated for6.3and removed for7.0.The documentation is also wrong and should be fixed (ideally after this pull request is merged).
Guidance is requested to add a test (current failures unrelated) 🙏