8000 [Configuration] Using MicroKernelTrait::getBundlesPath with Multiple Kernels by a-menshchikov · Pull Request #15423 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

[Configuration] Using MicroKernelTrait::getBundlesPath with Multiple Kernels #15423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 23, 2021
Merged

[Configuration] Using MicroKernelTrait::getBundlesPath with Multiple Kernels #15423

merged 1 commit into from
Sep 23, 2021

Conversation

a-menshchikov
Copy link
Contributor

@a-menshchikov a-menshchikov mentioned this pull request Jun 8, 2021
Merged
@javiereguiluz javiereguiluz added the Waiting Code Merge Docs for features pending to be merged label Jun 9, 2021
@carsonbot carsonbot added this to the next milestone Jun 9, 2021
fabpot added a commit to symfony/symfony that referenced this pull request Sep 8, 2021
@fabpot
feature #41566 [FrameworkBundle] Introduced new method for getting bu…
7c531f5 
…ndles config path (a-menshchikov)

This PR was merged into the 5.4 branch.

Discussion
----------

[FrameworkBundle] Introduced new method for getting bundles config path

| Q             | A
| ------------- | ---
| Branch?       | 5.4
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| Tickets       |
| License       | MIT
| Doc PR        | symfony/symfony-docs#15423

At the moment bundles path duplicated in MicroKernelTrait: in `registerBundles` and `registerContainerConfiguration` methods. This leads to need to override the both methods if bundles config stored by custom path (e.g. when multiple kernels used).

The new method allows override the only itself when custom path is used.

Commits
-------

b81b489 Introduced new method for getting bundles config path
symfony-splitter pushed a commit to symfony/framework-bundle that referenced this pull request Sep 8, 2021
@fabpot
feature #41566 [FrameworkBundle] Introduced new method for getting bu…
693ee6d 
…ndles config path (a-menshchikov)

This PR was merged into the 5.4 branch.

Discussion
----------

[FrameworkBundle] Introduced new method for getting bundles config path

| Q             | A
| ------------- | ---
| Branch?       | 5.4
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| Tickets       |
| License       | MIT
| Doc PR        | symfony/symfony-docs#15423

At the moment bundles path duplicated in MicroKernelTrait: in `registerBundles` and `registerContainerConfiguration` methods. This leads to need to override the both methods if bundles config stored by custom path (e.g. when multiple kernels used).

The new method allows override the only itself when custom path is used.

Commits
-------

b81b489631 Introduced new method for getting bundles config path
@javiereguiluz javiereguiluz added Status: Reviewed and removed Status: Needs Review Waiting Code Merge Docs for features pending to be merged labels Sep 23, 2021
@javiereguiluz javiereguiluz modified the milestones: next, 5.4 Sep 23, 2021
@javiereguiluz javiereguiluz merged commit 438afbf into symfony:5.4 Sep 23, 2021
@javiereguiluz
Copy link
Member

Thank you Alexander!

@a-menshchikov a-menshchikov deleted the bundles_path branch September 23, 2021 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
3 participants
@a-menshchikov @javiereguiluz @carsonbot
0