minor #15423 [Configuration] Using MicroKernelTrait::getBundlesPath with Multiple Kernels (a-menshchikov)

javiereguiluz · javiereguiluz · commit 438afbfd7e91 · 2021-09-23T10:57:53.000+02:00
This PR was merged into the 5.4 branch. Discussion ---------- [Configuration] Using MicroKernelTrait::getBundlesPath with Multiple Kernels See symfony/symfony#41566 Commits ------- a69f6b3 MicroKernelTrait::getBundlesPath
diff --git a/configuration/multiple_kernels.rst b/configuration/multiple_kernels.rst
@@ -91,15 +91,9 @@ files so they don't collide with the files from ``src/Kernel.php``::
     {
         use MicroKernelTrait;
 
-        public function registerBundles()
+        public function getProjectDir(): string
         {
-            // load only the bundles strictly needed for the API
-            $contents = require $this->getProjectDir().'/config/api_bundles.php';
-            foreach ($contents as $class => $envs) {
-                if ($envs[$this->environment] ?? $envs['all'] ?? false) {
-                    yield new $class();
-                }
-            }
+            return \dirname(__DIR__);
         }
 
         public function getCacheDir(): string
@@ -131,6 +125,12 @@ files so they don't collide with the files from ``src/Kernel.php``::
             $routes->import('../config/api/{routes}/*.yaml');
             // ... load only the config routes strictly needed for the API
         }
+
+        private function getBundlesPath(): string
+        {
+            // load only the bundles strictly needed for the API
+            return $this->getProjectDir().'/config/api_bundles.php';
+        }
     }
 
 Step 3) Define the Kernel Configuration

Original file line number	Diff line number	Diff line change
@@ -91,15 +91,9 @@ files so they don't collide with the files from ``src/Kernel.php``::
`91`	`91`	`{`
`92`	`92`	`use MicroKernelTrait;`
`93`	`93`
`94`		`- public function registerBundles()`
	`94`	`+ public function getProjectDir(): string`
`95`	`95`	`{`
`96`		`- // load only the bundles strictly needed for the API`
`97`		`- $contents = require $this->getProjectDir().'/config/api_bundles.php';`
`98`		`- foreach ($contents as $class => $envs) {`
`99`		`- if ($envs[$this->environment] ?? $envs['all'] ?? false) {`
`100`		`- yield new $class();`
`101`		`- }`
`102`		`- }`
	`96`	`+ return \dirname(__DIR__);`
`103`	`97`	`}`
`104`	`98`
`105`	`99`	`public function getCacheDir(): string`
@@ -131,6 +125,12 @@ files so they don't collide with the files from ``src/Kernel.php``::
`131`	`125`	`$routes->import('../config/api/{routes}/*.yaml');`
`132`	`126`	`// ... load only the config routes strictly needed for the API`
`133`	`127`	`}`
	`128`	`+`
	`129`	`+ private function getBundlesPath(): string`
	`130`	`+ {`
	`131`	`+ // load only the bundles strictly needed for the API`
	`132`	`+ return $this->getProjectDir().'/config/api_bundles.php';`
	`133`	`+ }`
`134`	`134`	`}`
`135`	`135`
`136`	`136`	`Step 3) Define the Kernel Configuration`