8000 Document composer sync recipe force option by noniagriconomie · Pull Request #14001 · symfony/symfony-docs · GitHub
[go: up one dir, main page]

Skip to content

Document composer sync recipe force option #14001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

noniagriconomie
Copy link
Contributor
@noniagriconomie noniagriconomie commented Jul 27, 2020

Small improvement on the upgrade packages process
It may help the process of upgrading/reinstalling to get latest recipe code

Also fix #12698 👍

edit: maybe check also #13320 as it is very similar :)


.. code-block:: terminal

$ composer sync-recipes --force
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should recommend this command composer recipes:install vendor/package --force -v to update one by one and -v for more information about the update

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maxhelias yes i see your idea
but as the upper code is a full composer update, that is why i added here a full "recipes update"

the -v option can be added indeed :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So just composer recipes:install --force -v will have the same behavior

@wouterj
Copy link
Member
wouterj commented Oct 3, 2020

Hi @noniagriconomie! I'm a bit unsure about how I missed this PR when merging #13320 . To me, it seems like the changes in this PR would add duplicate information the upgrade guides now that the other PR is merged. Is there anything left to do in this PR, or should it be closed?

Again, sorry for loosing your changes and thanks a lot for the time you've spent to improve the docs for everyone!

@noniagriconomie
Copy link
Contributor Author

@wouterj no worry, the main goal was to properly document the process of updating the recipes
this one (sync-recipe) or the other (install --force) it is ok for me

just to be precise, i just think in a doc part of "Upgrading/Updating Recipes"
i found the "install" weird, thus prefering the "sync" wording/action

Feel free to close this one if the wording is ok
Also i think you can close the related issue #12698 :)

@javiereguiluz
Copy link
Member

I agree with Wouter and that's why we're closing this without merging. Please, note that this RST file is included just before the other RST that explains the update of recipes (https://github.com/symfony/symfony-docs/blob/5.x/setup/_update_recipes.rst.inc) and which talks about --force option and the problem that it introduces.

So, this RST file is included in other articles which don't include the "_update_recipes.rst.inc", but that's fine because it's about updating patch/minor Symfony versions.

Thanks for understanding!

@noniagriconomie noniagriconomie deleted the feature-composer-sync-recipe branch April 22, 2021 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
0