8000 Add an explain section to update symfony recipes by maxhelias · Pull Request #13320 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

Add an explain section to update symfony recipes #13320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
< 8000 /div>
Merged
merged 1 commit into from
Aug 26, 2020
Merged

Add an explain section to update symfony recipes #13320

merged 1 commit into from
Aug 26, 2020

Conversation

maxhelias
Copy link
Contributor

More documentation about new command for update recipe

@maxhelias maxhelias changed the base branch from master to 4.4 March 9, 2020 09:20
@maxhelias maxhelias mentioned this pull request Mar 9, 2020
Closed
@maxhelias
Copy link
Contributor Author

friendly ping @weaverryan 😄

@weaverryan
Copy link
Member

Sorry I missed this. It makes total sense. When we have duplicated sections like this, we can isolate that section into its own file and use include:: to include it - see reference/constraints/Choice.rst for an option it includes /reference/constraints/_payload-option.rst.inc (we always end the included files in .inc so that they are not parsed as standalone files). Could you isolate this section into a .inc file and include from both documents?

Thanks!

@maxhelias maxhelias mentioned this pull request Jun 11, 2020
Closed
@maxhelias
Copy link
Contributor Author
maxhelias commented Aug 17, 2020 •
edited
Loading

poke @weaverryan or @wouterj 😉

wouterj
wouterj approved these changes Aug 17, 2020
View reviewed changes
Copy link
Member
@wouterj wouterj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@noniagriconomie noniagriconomie mentioned this pull request Aug 21, 2020
Closed
@xabbuh xabbuh added this to the 4.4 milestone Aug 26, 2020
@wouterj
Copy link
Member
wouterj commented Aug 26, 2020

Thanks for your work on this topic, Maxime!

@wouterj wouterj merged commit bec8616 into symfony:4.4 Aug 26, 2020
@maxhelias maxhelias deleted the update-recipes branch August 26, 2020 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wouterj wouterj wouterj approved these changes

@xabbuh xabbuh xabbuh approved these changes

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
5 participants
@maxhelias @weaverryan @wouterj @xabbuh @carsonbot
0