Replace deprecated ObjectManager #13131
Conversation
There was a problem hiding this comment.
I do not completely understand the changes. Aren't the namespace changes about removing the Common part?
So Doctrine\Common\Persistence\ObjectManager should become Doctrine\Persistence\ObjectManager. ManagerRegistry is a registry holding all ObjectManager's, so it's not a one to one replacement for ObjectManager.
This is also what the deprecation messages suggests: https://github.com/doctrine/persistence/pull/71/files#diff-0e209770d31833077cce41eba53a171eR11-R17
f4557ad to
c067cc0
Compare
Whoops. Fixed! |
There was a problem hiding this comment.
Perfect! Thanks for your quick reaction.
I agree with merging this into 3.4, as symfony/symfony#34949 was targetted at 3.4 as well (and there is also already a 3.4 release containing this patch).
7743d52 to
a10dab6
Compare
|
Thank you @tvlooy. |
This PR was squashed before being merged into the 3.4 branch (closes #13131). Discussion ---------- Replace deprecated ObjectManager ```Doctrine\Common\Persistence\ObjectManager``` is deprecated and should be replaced with ```Doctrine\Persistence\ManagerRegistry``` this is supported in symfony/doctrine-bridge now symfony/doctrine-bridge@c94d84f Commits ------- a10dab6 Replace deprecated ObjectManager
Doctrine\Common\Persistence\ObjectManageris deprecated and should be replaced withDoctrine\Persistence\ManagerRegistrythis is supported in symfony/doctrine-bridge now symfony/doctrine-bridge@c94d84f