[DoctrineBridge] try to fix deprecations from doctrine/persistence #34949
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0221a63 to
ef83802
Compare
ef83802 to
8070aa7
Compare
8070aa7 to
53a4711
Compare
nicolas-grekas
commented
Dec 12, 2019
| @@ -51,7 +51,7 @@ public function configureOptions(OptionsResolver $resolver) | |||
| * | |||
| 8000 * @return ORMQueryBuilderLoader | |||
| */ | |||
| public function getLoader(ObjectManager $manager, $queryBuilder, $class) | |||
| public function getLoader(LegacyObjectManager $manager, $queryBuilder, $class) | |||
There was a problem hiding this comment.
changing the type would be a BC break
| @@ -22,7 +22,7 @@ | |||
| * | |||
| * @author Lukas Kahwe Smith <smith@pooteeweet.org> | |||
| */ | |||
| abstract class ManagerRegistry extends AbstractManagerRegistry implements ContainerAwareInterface | |||
| abstract class ManagerRegistry extends LegacyAbstractManagerRegistry implements ContainerAwareInterface | |||
There was a problem hiding this comment.
changing the type would be a BC break
| use Doctrine\ORM\EntityManager; | ||
|
|
||
| /** | ||
| * References Doctrine connections and entity managers. | ||
| * | ||
| * @author Fabien Potencier <fabien@symfony.com> | ||
| */ | ||
| interface RegistryInterface extends ManagerRegistryInterface | ||
| interface RegistryInterface extends LegacyManagerRegistry |
There was a problem hiding this comment.
changing the type would be a BC break
| @@ -40,15 +41,15 @@ public function getRepository(EntityManagerInterface $entityManager, $entityName | |||
| return $this->repositoryList[$repositoryHash] = $this->createRepository($entityManager, $entityName); | |||
| } | |||
|
|
|||
| public function setRepository(EntityManagerInterface $entityManager, $entityName, ObjectRepository $repository) | |||
| public function setRepository(EntityManagerInterface $entityManager, $entityName, LegacyObjectRepository $repository) | |||
There was a problem hiding this comment.
changing the type would be a BC break
| @@ -25,7 +25,7 @@ public function setContainer(ContainerInterface $container = null) | |||
| $this->container = $container; | |||
| } | |||
|
|
|||
| public function load(ObjectManager $manager) | |||
| public function load(LegacyObjectManager $manager) | |||
There was a problem hiding this comment.
changing the type would be a BC break
| @@ -273,7 +277,7 @@ public function configureOptions(OptionsResolver $resolver) | |||
| * | |||
| * @return EntityLoaderInterface | |||
| */ | |||
| abstract public function getLoader(ObjectManager $manager, $queryBuilder, $class); | |||
| abstract public function getLoader(LegacyObjectManager $manager, $queryBuilder, $class); | |||
There was a problem hiding this comment.
changing the type would be a BC break
There was a problem hiding this comment.
Would it really? It's a class alias, so they are the same thing, right?
There was a problem hiding this comment.
Not when v1.2 is checked out
nicolas-grekas
added a commit
that referenced
this pull request
Dec 12, 2019
…ersistence (nicolas-grekas) This PR was merged into the 3.4 branch. Discussion ---------- [DoctrineBridge] try to fix deprecations from doctrine/persistence | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Follows doctrine/persistence#71 But the BC layer is not working yet, as highlighted by the `XXX` in the attached patch. At least for the corresponding interfaces, doctrine/persistence should always alias the legacy name to the new one. /cc @greg0ire @alcaeus FYI Commits ------- 53a4711 [DoctrineBridge] try to fix deprecations from doctrine/persistence
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows doctrine/persistence#71
But the BC layer is not working yet, as highlighted by the
XXXin the attached patch.At least for the corresponding interfaces, doctrine/persistence should always alias the legacy name to the new one.already the case./cc @greg0ire @alcaeus FYI