Use Sphinx GithubAction instead of Travis #13061
Conversation
f8793ec to
c12b18b
Compare
|
I'm sorry but I don't know the internals of this well. Maybe @tucksaun can help us because he set up the SymfonyCloud integration and because he knows everything about SymfonyCloud. Thanks! |
Just ported what used to be on Platform.sh to SymfonyCloud, so sorry I can't tell either 🤷♂ |
|
Actually, according to 75e7177:
So that would be why |
|
Ok, but in this case we could add them to the |
for building the docs
9d15288 to
948728e
Compare
Lets see if it works |
Probably not because this is a usual command to upgrade |
|
Unfortunately in this PR there is no SymfonyCloud env deployed. Do we raise the allowed number of ENVs? Or can you force this PR to deploy? @tucksaun
Sounds reasonable |
f6023cd to
948728e
Compare
|
I dropped the package move, so no blocker here for now. We are good to go |
Actually it is deployed... don't know why the status is not updated 🤔 |
|
RTM from my side |
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: "Checkout" | ||
| uses: actions/checkout@v2 |
There was a problem hiding this comment.
What do you think about introducing a bit of vertical whitespace?
diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
index a019ca7a1..6fa41f61f 100644
--- a/.github/workflows/ci.yaml
+++ b/.github/workflows/ci.yaml
@@ -11,30 +11,42 @@ name: CI
jobs:
build:
name: Build
+
runs-on: ubuntu-latest
+
steps:
- name: "Checkout"
uses: actions/checkout@v2
+
- name: "Set up Python 3.x"
uses: actions/setup-python@v1
with:
python-version: '3.7' # Semantic version range syntax or exact version of a Python version
+
- name: "Display Python version"
run: python -c "import sys; print(sys.version)"
+
- name: "Install Sphinx dependencies"
run: sudo apt-get install python-dev build-essential
+
- name: "Install Sphinx"
run: pip install --user sphinx
+
- name: "INstall custom requirements via pip"
run: pip install -r _build/.requirements.txt
+
- name: "Build documentation"
run: make -C _build SPHINXOPTS=-nW html
+
doctor-rst:
name: DOCtor-RST
+
runs-on: ubuntu-latest
+
steps:
- name: "Checkout"
uses: actions/checkout@v2
+
- name: "Run DOCtor-RST"
uses: docker://oskarstark/doctor-rst
with:1d356a5 to
0084ec2
Compare
This PR was submitted for the master branch but it was squashed and merged into the 3.4 branch instead (closes #13061). Discussion ---------- Use Sphinx GithubAction instead of Travis This PR - [x] closes #12212 - [x] adds a GithubAction to provide much faster feedback - [x] removes TravisCI from the Checks - [x] uses the same python version `3.7` like SymfonyCloud, before Travis used `2.7` @javiereguiluz can you explain why do you need on SymfonyCloud: https://github.com/symfony/symfony-docs/blob/a69aece424ef2dd8a969219f797b1ffb55230097/.symfony.cloud.yaml#L55 Commits ------- 9144aab Address comments by @localheinzwq 5b2a1ca Formatting + name steps fb25022 Use one workflow file 5f3f62a Use GithubAction instead of Travis
This PR was submitted for the master branch but it was merged into the 4.4 branch instead. Discussion ---------- GitHub Actions: use docker image for CI build This is an enhancement to #13061 I think it's beneficial to use docker when possible, which allows contributors to exactly replicate CI conditions. This PR introduces a local action to do just that. cc @OskarStark Commits ------- e059c5b GitHub Actions: use docker container for CI build
This PR
3.7like SymfonyCloud, before Travis used2.7@javiereguiluz can you explain why do you need on SymfonyCloud:
symfony-docs/.symfony.cloud.yaml
Line 55 in a69aece