8000 GitHub Actions: use docker image for CI build by bendavies · Pull Request #13094 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

GitHub Actions: use docker image for CI build #13094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 23, 2020
Merged

GitHub Actions: use docker image for CI build #13094

merged 1 commit into from
Nov 23, 2020

Conversation

bendavies
Copy link
Contributor

This is an enhancement to #13061

I think it's beneficial to use docker when possible, which allows contributors to exactly replicate CI conditions.

This PR introduces a local action to do just that.

cc @OskarStark

@OskarStark
8000 Copy link
Contributor

Hi Ben 👋

Thanks for this improvement, not sure we need to be reproducable.
Is this image build all the time or is it cached?

@javiereguiluz WDYT?

@localheinz can you please leave your 2 cents here? Thanks!

@bendavies bendavies force-pushed the github-actions-use-docker branch from a3e3428 to f2cf33b Compare February 10, 2020 13:11
@bendavies
Copy link
Contributor Author

@OskarStark hey, this is just a personal preference really.
I just pushed a commit removing the custom action.

@bendavies bendavies force-pushed the github-actions-use-docker branch from f2cf33b to 42f1607 Compare February 10, 2020 13:13
OskarStark
OskarStark reviewed Feb 10, 2020
View reviewed changes
@bendavies bendavies force-pushed the github-actions-use-docker branch 2 times, most recently from fb1fb5b to 88b3232 Compare February 10, 2020 13:17
@javiereguiluz
Copy link
Member

@OskarStark I don't know much about GitHub actions, so you'll need to make a decision about this: is this something that fixes issues? improves things? Does it complicate anything? Would we lose something? etc. Thanks!

OskarStark
OskarStark approved these changes Sep 10, 2020
View reviewed changes
Copy link
Contributor
@OskarStark OskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks more easy + it looks faster.

Please don't merge yet, I am currently on a phone 📱 and will check this next week.

Thanks for your PR the ping @javiereguiluz

@OskarStark OskarStark self-assigned this Sep 10, 2020
@wouterj
Copy link
Member
wouterj commented Oct 21, 2020

Friendly ping @OskarStark :)

@OskarStark
Copy link
Contributor

Will check tomorrow, thanks

OskarStark
OskarStark reviewed Oct 21, 2020
View reviewed changes
@OskarStark OskarStark added this to the 4.4 milestone Nov 23, 2020
@OskarStark OskarStark changed the base branch from master to 4.4 November 23, 2020 06:26
@OskarStark OskarStark force-pushed the github-actions-use-docker branch from 88b3232 to e059c5b Compare November 23, 2020 06:26
@OskarStark
Copy link
Contributor

Thank you Ben.

@OskarStark OskarStark merged commit ce9ac45 into symfony:4.4 Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wouterj wouterj wouterj left review comments

@OskarStark OskarStark OskarStark approved these changes

@HeahDude HeahDude Awaiting requested review from HeahDude

@xabbuh xabbuh Awaiting requested review from xabbuh

Assignees

@OskarStark OskarStark

Labels
Status: Needs Review
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
5 participants
@bendavies @OskarStark @javiereguiluz @wouterj @carsonbot
0