-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
GitHub Actions: use docker image for CI build #13094
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi Ben 👋 Thanks for this improvement, not sure we need to be reproducable. @javiereguiluz WDYT? @localheinz can you please leave your 2 cents here? Thanks! |
a3e3428
to
f2cf33b
Compare
@OskarStark hey, this is just a personal preference really. |
f2cf33b
to
42f1607
Compare
fb1fb5b
to
88b3232
Compare
@OskarStark I don't know much about GitHub actions, so you'll need to make a decision about this: is this something that fixes issues? improves things? Does it complicate anything? Would we lose something? etc. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks more easy + it looks faster.
Please don't merge yet, I am currently on a phone 📱 and will check this next week.
Thanks for your PR the ping @javiereguiluz
Friendly ping @OskarStark :) |
Will check tomorrow, thanks |
88b3232
to
e059c5b
Compare
Thank you Ben. |
This is an enhancement to #13061
I think it's beneficial to use docker when possible, which allows contributors to exactly replicate CI conditions.
This PR introduces a local action to do just that.
cc @OskarStark