[PropertyAccess] Update the method directives #12811
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
approved these changes
Dec 14, 2019
Contributor
|
Thank you Javier. |
OskarStark
added a commit
that referenced
this pull request
Dec 14, 2019
…iluz) This PR was merged into the 4.3 branch. Discussion ---------- [PropertyAccess] Update the method directives I don't understand the reasoning for using the `:method:` directives in this way. It makes docs more verbose, it complicates maintenance and it removes the trailing `()` from method names, which is essential to make them look like methods. Commits ------- fc44076 [PropertyAccess] Update the method directives
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't understand the reasoning for using the
:method:directives in this way. It makes docs more verbose, it complicates maintenance and it removes the trailing()from method names, which is essential to make them look like methods.