8000 [PropertyAccess] Update the method directives by javiereguiluz · Pull Request #12811 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

[PropertyAccess] Update the method directives #12811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 14, 2019
Merged

[PropertyAccess] Update the method directives #12811

merged 1 commit into from
Dec 14, 2019

Conversation

javiereguiluz
Copy link
Member

I don't understand the reasoning for using the :method: directives in this way. It makes docs more verbose, it complicates maintenance and it removes the trailing () from method names, which is essential to make them look like methods.

@javiereguiluz javiereguiluz added this to the 4.3 milestone Dec 13, 2019
@OskarStark
Copy link
Contributor

Thank you Javier.

OskarStark added a commit that referenced this pull request Dec 14, 2019
@OskarStark
minor #12811 [PropertyAccess] Update the method directives (javieregu…
b2f2e52 
…iluz)

This PR was merged into the 4.3 branch.

Discussion
----------

[PropertyAccess] Update the method directives

I don't understand the reasoning for using the `:method:` directives in this way. It makes docs more verbose, it complicates maintenance and it removes the trailing `()` from method names, which is essential to make them look like methods.

Commits
-------

fc44076 [PropertyAccess] Update the method directives
@OskarStark OskarStark merged commit fc44076 into symfony:4.3 Dec 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

5A65 @OskarStark OskarStark OskarStark approved these changes

Assignees
No one assigned
Labels
PropertyAccess Status: Reviewed
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
3 participants
@javiereguiluz @OskarStark @carsonbot
0