Update micro_kernel_trait.rst #12722
Conversation
|
Can you please explain why we should change this? Thanks 🙏 |
|
Done !! |
|
Thank you. I did all the steps mentioned in the original paragraph. No errors, but when I add your proposed So I am against this change 👎 |
|
When i keep the current code i have this errror (PJ) But when i change by my code, i don't have any errors N.B : I 'm under linux/ubuntu |
|
Are you using Apache nginx? |
|
@OskarStark |
…et-magenta) This PR was submitted for the master branch but it was merged into the 3.4 branch instead (closes symfony#13032). Discussion ---------- fix: very_verbose mode shows estimated time Small typo in the doc, the format of the progressBar is missing the estimated time in the `very_verbose` mode the same typo is present in the other versions of the doc Commits ------- a0a68bc fix: very_verbose mode shows estimated time
…nterface are executed
…ements CompilerPassI… (l-vo) This PR was merged into the 3.4 branch. Discussion ---------- Fix compiler pass phase when extensions that implements CompilerPassI… Fix compiler pass phase when extensions that implements CompilerPassnterface are executed Commits ------- 0a255dc Fix compiler pass phase when extensions that implements CompilerPassInterface are executed
This PR was merged into the 3.4 branch.
Discussion
----------
[Lock] Default path for FlockStore
Hi everyone 👋
As noticed in the source code:
```php
/**
* @param string|null $lockPath the directory to store the lock, defaults to the system's temporary directory
*
* @throws LockStorageException If the lock directory doesn’t exist or is not writable
*/
public function __construct(string $lockPath = null)
{
if (null === $lockPath) {
$lockPath = sys_get_temp_dir();
}
if (!is_dir($lockPath) || !is_writable($lockPath)) {
throw new InvalidArgumentException(sprintf('The directory "%s" is not writable.', $lockPath));
}
$this->lockPath = $lockPath;
}
```
`sys_get_temp_dir` is the default path is null is given in the constructor, could it be a good idea to notice this? 🤔
Commits
-------
efbb0b3 refacto(Lock): FlockStore default path
…Toflar) This PR was squashed before being merged into the 3.4 branch (closes symfony#13063). Discussion ---------- Added reasoning to autowiring in public bundles Right now it's just a statement without any arguments which might confuse readers. Commits ------- 35d2e97 Added reasoning to autowiring in public bundles
|
Hi @amine-betari! I think I found the confusion: You are putting the file in To fix the confusion, I wanted to change this to put the filepath in a comment at the start of the codeblock (in commit f3fd946). Somehow, I completely messed up the commits in this PR, so I picked your commit and opened a new PR that I merged instead: #13088 Thanks for starting this PR and posting screenshots & details to help find out what's wrong here! |
* 3.4: [symfony#13000] Fixed newline [symfony#12722] Added filename comment to avoid confusion Update micro_kernel_trait.rst Update broken links
* 4.4: [symfony#13000] Fixed newline Update testing.rst [symfony#12722] Added filename comment to avoid confusion Update micro_kernel_trait.rst Update broken links
* 5.0: [symfony#13000] Fixed newline Update testing.rst [symfony#12722] Added filename comment to avoid confusion Update micro_kernel_trait.rst Update link for (No|Admin)Recipient Typo Update broken links
|
Hi @wouterj |
DIR returns home/aminebetari/Projects/Symfony/my-project/src
dirname(DIR) returns /home/aminebetari/Projects/Symfony/my-project
So if we keep in this example :
require
__DIR__.'/vendor/autoload.php';we will have an error because the path is not correctBut if we change by require
dirname(__DIR__).'/vendor/autoload.php';we will not have the error because we put the correct path