8000 fix: very_verbose mode shows estimated time by crozet-magenta · Pull Request #13032 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

fix: very_verbose mode shows estimated time #13032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 5, 2020
Merged

fix: very_verbose mode shows estimated time #13032

merged 1 commit into from
Feb 5, 2020

Conversation

crozet-magenta
Copy link
Contributor
@crozet-magenta crozet-magenta commented Feb 3, 2020 •
edited
Loading

Small typo in the doc, the format of the progressBar is missing the estimated time in the very_verbose mode

the same typo is present in the other versions of the doc

HeahDude
HeahDude approved these changes Feb 4, 2020
View reviewed changes
Copy link
Contributor
@HeahDude HeahDude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this fix!

@HeahDude HeahDude added this to the 3.4 milestone Feb 4, 2020
OskarStark
OskarStark approved these changes Feb 4, 2020
View reviewed changes
Copy link
Contributor
@OskarStark OskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@OskarStark OskarStark changed the base branch from master to 3.4 February 5, 2020 05:56
@OskarStark
Copy link
Contributor

Good catch, thanks Cassian.

OskarStark added a commit that referenced this pull request Feb 5, 2020
@OskarStark
minor #13032 fix: very_verbose mode shows estimated time (crozet-mage…
a306de1 
…nta)

This PR was submitted for the master branch but it was merged into the 3.4 branch instead (closes #13032).

Discussion
----------

fix: very_verbose mode shows estimated time

Small typo in the doc, the format of the progressBar is missing the estimated time in the `very_verbose` mode

the same typo is present in the other versions of the doc

Commits
-------

a0a68bc fix: very_verbose mode shows estimated time
@OskarStark OskarStark merged commit a0a68bc into symfony:3.4 Feb 5, 2020
@crozet-magenta crozet-magenta deleted the patch-1 branch February 6, 2020 13:05
@HeahDude HeahDude mentioned this pull request Feb 19, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark OskarStark approved these changes

@HeahDude HeahDude HeahDude approved these changes

Assignees
No one assigned
Labels
Console Status: Reviewed
Projects
None yet
Milestone
3.4
Development

Successfully merging this pull request may close these issues.
4 participants
@crozet-magenta @OskarStark @HeahDude @carsonbot
0