action_method is missing $task variable #10200
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's not clear from the docs, but user has to first create the `$task` variable. In the second example bellow it's more clear thanks to `// ...`. This makes it a bit more explicit here as well.
xabbuh
approved these changes
Aug 21, 2018
|
Thank you @TomasVotruba. |
xabbuh
added a commit
that referenced
this pull request
Aug 21, 2018
This PR was submitted for the 4.1 branch but it was merged into the 2.8 branch instead (closes #10200). Discussion ---------- action_method is missing $task variable It's not clear from the docs, but user has to first create the `$task` variable. In the second example bellow it's more clear thanks to `// ...`. This makes it a bit more explicit here as well. Commits ------- 5ada0ef action_method is missing $task variable
xabbuh
added a commit
that referenced
this pull request
Aug 21, 2018
weaverryan
added a commit
that referenced
this pull request
Aug 28, 2018
* 2.8:
{% if label is not same as(false) and required %}
Shorten ternary operator
Fix wrong usage in custom authenticator checking if password is invalid
update hardcoded 5.1 version link
Add undocumented sortByAccessedTime, sortByChangedTime and sortByModifiedTime methods in finder component
Update bugs.rst
[#10200] remove trailing spaces
action_method is missing $task variable
Fix bad link
weaverryan
added a commit
that referenced
this pull request
Aug 28, 2018
* 3.4:
{% if label is not same as(false) and required %}
Update service_container.rst
Shorten ternary operator
Fix wrong usage in custom authenticator checking if password is invalid
[Process] Fix typo in Process object initialization
update hardcoded 5.1 version link
Add undocumented sortByAccessedTime, sortByChangedTime and sortByModifiedTime methods in finder component
Update bugs.rst
[#10200] remove trailing spaces
action_method is missing $task variable
Fix bad link
weaverryan
added a commit
that referenced
this pull request
Aug 28, 2018
* 4.1:
{% if label is not same as(false) and required %}
minor language tweak
Update service_container.rst
Fix wrong exception used in custom authentication provider example
[Console] Replace useless usage of ContainerAwareCommand
Shorten ternary operator
Fix wrong usage in custom authenticator checking if password is invalid
[Process] Fix typo in Process object initialization
update hardcoded 5.1 version link
Explain dump server usage outside of Symfony
Add undocumented sortByAccessedTime, sortByChangedTime and sortByModifiedTime methods in finder component
Update bugs.rst
[#10200] remove trailing spaces
action_method is missing $task variable
[#10177] fix markup
Clarifying when you need to or don't need to install the server bundle
Fix bad link
Update setup.rst
Also requiring annotations so they can be used
royklutman
pushed a commit
to royklutman/symfony-docs
that referenced
this pull request
Sep 21, 2018
royklutman
added a commit
to royklutman/symfony-docs
that referenced
this pull request
Sep 21, 2018
This reverts commit 95dc4ca.
Guikingone
pushed a commit
to Guikingone/symfony-docs
that referenced
this pull request
Feb 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not clear from the docs, but user has to first create the
$taskvariable.In the second example bellow it's more clear thanks to
// ....This makes it a bit more explicit here as well.