8000
Page Creation Small Changes #10177
Closed
Page Creation Small Changes #10177
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bit confusing to the user with the extra stuff showing on the screen.
weaverryan
approved these changes
Aug 18, 2018
There was a problem hiding this comment.
I like this a lot! This page was last updated when symfony/skeleton was used. So, indeed, some of the assumptions are now wrong.
The trickiest part for me is no longer saying you should install Twig. The changes in this PR should be accepted in my opinion. However, it does make things harder for symfony/skeleton users. I think the best we can do is to add the composer require lines at the top of the specific topic guides (e.g. the templating.rst page), but not in these few getting started pages (we should assume website-skeleton all the way).
Thanks @ahinkle!
weaverryan
added a commit
that referenced
this pull request
Aug 28, 2018
* 4.1:
{% if label is not same as(false) and required %}
minor language tweak
Update service_container.rst
Fix wrong exception used in custom authentication provider example
[Console] Replace useless usage of ContainerAwareCommand
Shorten ternary operator
Fix wrong usage in custom authenticator checking if password is invalid
[Process] Fix typo in Process object initialization
update hardcoded 5.1 version link
Explain dump server usage outside of Symfony
Add undocumented sortByAccessedTime, sortByChangedTime and sortByModifiedTime methods in finder component
Update bugs.rst
[#10200] remove trailing spaces
action_method is missing $task variable
[#10177] fix markup
Clarifying when you need to or don't need to install the server bundle
Fix bad link
Update setup.rst
Also requiring annotations so they can be used
Guikingone
pushed a commit
to Guikingone/symfony-docs
that referenced
this pull request
Feb 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes changes to the page creation page for the user to easily understand the breakdown and removes unnecessary areas.
Move the Controller tip to the example controller area instead of the annotation route. The hint currently drops unexpectedly to the end user after a routes discussion.
The
profiler-packis already included with the Symfony package. Removed composer installation area. Additionally, users may be confused why there is more than one route when it declares "You should see one route" -- added a note on debugging routes.Twig is automatically included with Symfony. No need to direct the user to require and install it with composer.
Shorter, more elegant array syntax on the
render()example.