8000 ExpressionLanguage: Variable values have to be passed to the parser · Issue #4578 · symfony/symfony-docs · GitHub
[go: up one dir, main page]
Skip to content

ExpressionLanguage: Variable values have to be passed to the parser #4578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
xabbuh opened this issue Dec 3, 2014 · 0 comments
Closed

ExpressionLanguage: Variable values have to be passed to the parser #4578

xabbuh opened this issue Dec 3, 2014 · 0 comments
Labels
actionable Clear and specific issues ready for anyone to take them. bug ExpressionLanguage good first issue Ideal for your first contribution! (some Symfony experience may be required)

Comments

@xabbuh
Copy link
Member
xabbuh commented Dec 3, 2014

When an expression is parsed using the ExpressionLanguage::parse() method, you will have to pass the actual variable values (see symfony/symfony#12800). This means that you have to pass an empty array when the expression doesn't contain any variables. This is currently wrong at least in the examples shown on http://symfony.com/doc/2.5/components/expression_language/caching.html#using-parsed-and-serialized-expressions.
@xabbuh xabbuh added bug good first issue Ideal for your first contribution! (some Symfony experience may be required) actionable Clear and specific issues ready for anyone to take them. ExpressionLanguage labels Dec 3, 2014
@xabbuh xabbuh mentioned this issue Dec 3, 2014
Closed
@xabbuh xabbuh changed the title ExpressionLanguage: Values for expressions to be parsed are mandatory ExpressionLanguage: Variable values for expressions to be parsed are mandatory Dec 3, 2014
@xabbuh xabbuh changed the title ExpressionLanguage: Variable values for expressions to be parsed are mandatory ExpressionLanguage: Variable values have to be passed to the parser Dec 3, 2014
@xabbuh xabbuh mentioned this issue Dec 5, 2014
Merged
wouterj added a commit that referenced this issue Dec 17, 2014
@wouterj
bug #4598 [ExpressionLanguage] add missing argument (xabbuh)
8b611e2 
This PR was merged into the 2.5 branch.

Discussion
----------

[ExpressionLanguage] add missing argument

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | 2.5+
| Fixed tickets | #4578

Commits
-------

4801a3c [ExpressionLanguage] add missing argument
@wouterj wouterj closed this as completed Dec 17, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
actionable Clear and specific issues ready for anyone to take them. bug ExpressionLanguage good first issue Ideal for your first contribution! (some Symfony experience may be required)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wouterj @xabbuh
0