8000 [ExpressionLanguage] added default value in parse method by bamarni · Pull Request #12800 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[ExpressionLanguage] added default value in parse method #12800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[ExpressionLanguage] added default value in parse method #12800

wants to merge 1 commit into from

Conversation

bamarni
Copy link
Contributor
@bamarni bamarni commented Dec 2, 2014
Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes (component test suite)
License MIT

I was trying to follow doc instructions from here : http://symfony.com/doc/2.5/components/expression_language/caching.html#using-parsed-and-serialized-expressions.

@fabpot
Copy link
Member
fabpot commented Dec 3, 2014

The doc should be fixed instead. I made the values argument mandatory on purpose; first because it's very rare to parse an expression without any variables, then, not passing anything should be a conscious decision.

Can you open a PR on the docs? Thanks.

@fabpot fabpot closed this Dec 3, 2014
@xabbuh xabbuh mentioned this pull request Dec 3, 2014
Closed
@xabbuh
Copy link
Member
xabbuh commented Dec 3, 2014

see symfony/symfony-docs#4578

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bamarni @fabpot @xabbuh
0