8000 [Form] Add missing type hint by armetiz · Pull Request #8045 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[Form] Add missing type hint #8045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[Form] Add missing type hint #8045

wants to merge 2 commits into from

Conversation

armetiz
Copy link
Contributor
@armetiz armetiz commented May 15, 2013

No description provided.

fabpot
fabpot reviewed May 15, 2013
View reviewed changes
src/Symfony/Bridge/Doctrine/Form/ChoiceList/ORMQueryBuilderLoader.php
* @param QueryBuilder|\Closure $queryBuilder
* @param EntityManager $manager
* @param string $class
* @param QueryBuilder|\Closure $queryBuilder
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have too many whitespaces beween the type hint and the variable name

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in : armetiz@143aa92

@fabpot fabpot closed this in a6dd5db May 15, 2013
stof
stof reviewed May 16, 2013
View reviewed changes
src/Symfony/Bridge/Doctrine/Form/ChoiceList/ORMQueryBuilderLoader.php
@@ -13,6 +13,7 @@

use Symfony\Component\Form\Exception\UnexpectedTypeException;
use Doctrine\ORM\QueryBuilder;
use Doctrine\ORM\EntityManagerInterface;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is wrong. There is no such interface in Doctrine stable. @fabpot please revert

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well done @stof.
EntityManagerInterface will be available in 2.4 stable version

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, but we are compatible with Doctrine ORM 2.2+

fabpot added a commit that referenced this pull request May 16, 2013
@fabpot
Revert "merged branch armetiz/master (PR #8045)"
1231d47 
This reverts commit a6dd5db, reversing
changes made to da6f190.
fabpot added a commit that referenced this pull request May 16, 2013
@fabpot
Merge branch '2.3'
b51de93 
* 2.3:
  Added missing column to the form's table layout
  Bumped Icu dependency to RC
  Update validators.ru.xlf
  remove check for PHP bug #50731
  adding missing Farsi translations
  Revert "merged branch armetiz/master (PR #8045)"
@jakzal jakzal mentioned this pull request May 16, 2013
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
50A0 No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@armetiz @fabpot @stof
0