8000 [Form] Add missing type hint by armetiz · Pull Request #8045 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content
8000

[Form] Add missing type hint #8045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[Form] Add missing type hint #8045

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
197b221
Add type hint for EntityManagerInterface
armetiz May 15, 2013
143aa92
PSR - Fix spaces.
armetiz May 15, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Add type hint for EntityManagerInterface
  • Loading branch information
@armetiz
armetiz committed May 15, 2013
commit 197b221c6bc69bab2adf5764a4817f473080ca60
9 changes: 5 additions & 4 deletions src/Symfony/Bridge/Doctrine/Form/ChoiceList/ORMQueryBuilderLoader.php
View file
Open in desktop
10000
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@

use Symfony\Component\Form\Exception\UnexpectedTypeException;
use Doctrine\ORM\QueryBuilder;
use Doctrine\ORM\EntityManagerInterface;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is wrong. There is no such interface in Doctrine stable. @fabpot please revert

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well done @stof.
EntityManagerInterface will be available in 2.4 stable version

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, but we are compatible with Doctrine ORM 2.2+

use Doctrine\DBAL\Connection;

/**
Expand All @@ -33,13 +34,13 @@ class ORMQueryBuilderLoader implements EntityLoaderInterface
/**
* Construct an ORM Query Builder Loader
*
* @param QueryBuilder|\Closure $queryBuilder
* @param EntityManager $manager
* @param string $class
* @param QueryBuilder|\Closure $queryBuilder
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have too many whitespaces beween the type hint and the variable name

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed in : armetiz@143aa92

* @param EntityManagerInterface $manager
* @param string $class
*
* @throws UnexpectedTypeException
*/
public function __construct($queryBuilder, $manager = null, $class = null)
public function __construct($queryBuilder, EntityManagerInterface $manager = null, $class = null)
{
// If a query builder was passed, it must be a closure or QueryBuilder
// instance
Expand Down
0