8000 Fix param docs for PropertyAccessor read method by jmikola · Pull Request #7498 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

Fix param docs for PropertyAccessor read method #7498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Fix param docs for PropertyAccessor read method #7498

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2d4c1d8
Fix param docs for PropertyAccessor read method
jmikola Mar 27, 2013
bdb8473
[PropertyAccess] Remove trailing periods from doc blocks
jmikola Mar 27, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fix param docs for PropertyAccessor read method
  • Loading branch information
@jmikola
jmikola committed Mar 27, 2013
commit 2d4c1d83584171140eacb00650a12fa1bf813b36
4 changes: 2 additions & 2 deletions src/Symfony/Component/PropertyAccess/PropertyAccessorInterface.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,8 +72,8 @@ public function setValue(&$objectOrArray, $propertyPath, $value);
*
* If none of them are found, an exception is thrown.
*
* @param object|array $objectOrArray The object or array to traverse
* @param string|PropertyPathInterface $propertyPath The property path to modify.
* @param object|array $objectOrArray The object or array to traverse.
* @param string|PropertyPathInterface $propertyPath The property path to read.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove the dots at the end of this line and the line above?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took a look through the component and noticed there were many trailing periods. bdb8473 should catch them all.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAIK, you should not fix coding style for the existing code.

*
* @return mixed The value at the end of the property path
*
Expand Down
0