Fix param docs for PropertyAccessor read method #7498
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
| Q | A |
|---|---|
| Fixed tickets | none |
| License | MIT |
| * @param object|array $objectOrArray The object or array to traverse | ||
| * @param string|PropertyPathInterface $propertyPath The property path to modify. | ||
| * @param object|array $objectOrArray The object or array to traverse. | ||
| * @param string|PropertyPathInterface $propertyPath The property path to read. |
There was a problem hiding this comment.
Can you remove the dots at the end of this line and the line above?
There was a problem hiding this comment.
I took a look through the component and noticed there were many trailing periods. bdb8473 should catch them all.
There was a problem hiding this comment.
AFAIK, you should not fix coding style for the existing code.
Periods were left in place for entries with multiple sentences/statements.
|
Can you submit this PR on the 2.2 branch instead? |
|
Ah, yes. Didn't realize that |
fabpot
added a commit
that referenced
this pull request
Mar 28, 2013
This PR was merged into the 2.2 branch. Discussion ---------- [PropertyAccess] Documentation cleanup | Q | A | ------------- | --- | Fixed tickets | none | License | MIT Resubmission of #7498 Commits ------- 8aaa6ef [PropertyAccess] Remove trailing periods from doc blocks d78fec9 Fix param docs for PropertyAccessor read method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.