[TwigBridge] fixed trans twig extractor #7206
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #6943 |
…her visitor to get the value when it is a constant
| @@ -68,6 +74,10 @@ public function enterNode(\Twig_NodeInterface $node, \Twig_Environment $env) | |||
| */ | |||
| public function leaveNode(\Twig_NodeInterface $node, \Twig_Environment $env) | |||
| { | |||
| if ($node instanceof TransDefaultDomainNode) { | |||
| return false; | |||
There was a problem hiding this comment.
This is wrong. A visitor has to return a node, not a boolean
There was a problem hiding this comment.
then the phpdoc of the interface is wrong
fabpot
added a commit
that referenced
this pull request
Feb 28, 2013
This PR was squashed before being merged into the 2.1 branch (closes #7206). Commits ------- bae83c7 [TwigBridge] fixed trans twig extractor Discussion ---------- [TwigBridge] fixed trans twig extractor | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #6943
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.