10000 make Translation:update Command more robust · Issue #5500 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

make Translation:update Command more robust #5500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Gladhon opened this issue Sep 12, 2012 · 8 comments
Closed

make Translation:update Command more robust #5500

Gladhon opened this issue Sep 12, 2012 · 8 comments
Labels
Good first issue Ideal for your first contribution! (some Symfony experience may be required) Translation

Comments

@Gladhon
Copy link
Gladhon commented Sep 12, 2012

Nowadays i'm often getting Error's if I try to update translation-file like this:
[Twig_Error_Runtime]
Attribute "value" does not exist for Node "Twig_Node_Expression_GetAttr".

It seem's it come's from dynamic part of a transaltion. The Problem is, that it abort on the first twig error, it would be nice if the command run through and make what he can make. --ignore-expetions

Or just get in a prefix-viewfolder as argument:

    $extractor->extract($foundBundle->getPath().'/Resources/views/'.$viewfolder, $catalogue);
@Elexy
Copy link
Elexy commented Nov 24, 2012

Can you provide more information on how to reproduce this?
I cannot seem to break it in the way you mentioned

@dlsniper
Copy link
Contributor
dlsniper commented Jan 9, 2013

@Gladhon Could you please provide some feedback on this? A small sample of the text that you want to translate or a quick gist should be very helpful.

Thanks!

@Gladhon
Copy link
Author
Gladhon commented Jan 10, 2013

It seem's to five problems, if I do translation with variables.

{{ value.value|trans({}, "Forms") }} 
{{ ('my.'~var) |trans({}, "Forms") }}

@mvrhov
Copy link
mvrhov commented Jan 10, 2013

You can't extract anything from the above template as extractor doesn't run the code, so naturally this would be missing from translation anyway. JMSTranslationBundle solves this but you'll have to provide all the cases from php code.

@Gladhon
Copy link
Author
Gladhon commented Jan 10, 2013

It's okay, that's extractor don't can extraxt the translations above. But, it's would be nice if it's extract all translations that it can do and not abort with a Exception.

@jfsimon
Copy link
Contributor
jfsimon commented Mar 5, 2013

I tried to get this error by:

  • adding {{ (test~'test')|trans }} in a template
  • launching ./app/console translation:uodate SensioTestingBundle --dump-messages command

I tried different tags of the 2.1 branch but I cant get any error, my message is just ignored.
That said I already saw the error mentioned when making tests with trans_default_domain tag.

@Gladhon The #7206 could hav solved your problem. Could you update and try again?

@jfsimon
Copy link
Contributor
jfsimon commented Jul 10, 2013

Ping @Gladhon

if (composer update solved your problem) {
    please close the issue;
} else {
    do you have some precisions about it?
}

Thanks!

@cordoval
Copy link
Contributor
cordoval commented Dec 1, 2013

ping @Gladhon , i am also confirming this has been fixed in master, if your problem persists please reopen ticket

@cordoval cordoval closed this as completed Dec 1, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good first issue Ideal for your first contribution! (some Symfony experience may be required) Translation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@jfsimon @cordoval @Elexy @mvrhov @dlsniper @Gladhon
0