8000 [UPGRADE-2.2.md] add information about route pattern => path renaming by dbu · Pull Request #6826 · symfony/symfony · GitHub
[go: up one dir, main page]

Skip to content

[UPGRADE-2.2.md] add information about route pattern => path renaming #6826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

dbu
Copy link
Contributor
@dbu dbu commented Jan 21, 2013
Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

This updates the UPDGRADE-2.2.md with missing information.

add information about route pattern => path renaming
@@ -275,6 +275,10 @@
$collection->addPrefix('/prefix', array(...), array(...));
$parentCollection->addCollection($collection);
```
* What was called `pattern` is now called `path` in the routing configuration. The old key `pattern`
is deprecated and will be removed in Symfony 3.0.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fabpot
Copy link
Member
fabpot commented Jan 21, 2013

@fabpot fabpot closed this Jan 21, 2013
@dbu
Copy link
Contributor Author
8000 dbu commented Jan 21, 2013

ok. the change made problems for me when i upgraded from 2.1 to the current master so i thought other people would also want to be notified for 2.2. but maybe the cmf routing is indeed the only thing using core routing in a way that actually makes a difference. (we had a name collision on getPath and overwrite get/setPattern)

@dbu dbu deleted the patch-1 branch January 21, 2013 19:52
@wouterj
Copy link
Member
wouterj commented Jan 21, 2013

Well, there is some confusing about this because it is added in an UPGRADE-3.0.md file. It looks like it is important for 3.0 (which does not exists yet :)), but actualy it is important for 2.2, I think?

@fabpot
Copy link
Member
fabpot commented Jan 21, 2013

The thing is that you can update this when upgrading to 2.2 but you can also wait until 3.0, your choice.

@wouterj
Copy link
Member
wouterj commented Jan 21, 2013

But they are deprecated in 2.2, aren't they? So we should get a 'deprecation' message if we use the old names?

Related, should we upgrade the docs for this change, or should we wait until 3.0?

@fabpot
Copy link
Member
fabpot commented Jan 21, 2013

No, that's the big difference. There is no deprecation message as it will be supported for all versions of Symfony 2.

@dbu
Copy link
Contributor Author
dbu commented Jan 21, 2013

@wouterj though there is a @deprecated annotation on the Route::getPattern method. the doc is already updated for 2.2. new projects at least should use the new way.

@wouterj
Copy link
Member
wouterj commented Jan 21, 2013

@fabpot and @dbu thank you, I understand it now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0