8000 [BC Break][Debug] #2042 implementation of fatal error logging by Koc · Pull Request #6474 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content

[BC Break][Debug] #2042 implementation of fatal error logging #6474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

[BC Break][Debug] #2042 implementation of fatal error logging #6474

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1bb5677
#2042 fatal error logging under when debug enabled
Koc Apr 10, 2013
a5e38d4
minimize and document BC breaks
Koc Apr 25, 2013
6ca1339
fatal errors logging in production environment #2042
Koc Apr 25, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
minimize and document BC breaks
  • Loading branch information
@Koc
Koc committed Apr 25, 2013
commit a5e38d459feb366a0ffe94ee8d352fdb2897d40a
2 changes: 1 addition & 1 deletion src/Symfony/Component/Debug/ErrorHandler.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ public function setLevel($level)
$this->level = null === $level ? error_reporting() : $level;
}

public static function setLogger($channel, LoggerInterface $logger)
public static function setLogger(LoggerInterface $logger, $channel = 'deprecation')
{
self::$loggers[$channel] = $logger;
}
Expand Down
2 changes: 1 addition & 1 deletion src/Symfony/Component/Debug/Tests/ErrorHandlerTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ public function testHandle()
;

$handler = ErrorHandler::register(E_USER_DEPRECATED);
$handler->setLogger('deprecation', $logger);
$handler->setLogger($logger);
$handler->handle(E_USER_DEPRECATED, 'foo', 'foo.php', 12, 'foo');

restore_error_handler();
Expand Down
3 changes: 2 additions & 1 deletion src/Symfony/Component/HttpKernel/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ CHANGELOG
2.3.0
-----

* [BC BREAK] renamed `Symfony\Component\HttpKernel\EventListener\DeprecationLoggerListener` to `Symfony\Component\HttpKernel\EventListener\ErrorsLoggerListener` and changed its constructor
* deprecated `Symfony\Component\HttpKernel\Debug\ErrorHandler`, `Symfony\Component\HttpKernel\Debug\ExceptionHandler`,
`Symfony\Component\HttpKernel\Exception\FatalErrorException`, and `Symfony\Component\HttpKernel\Exception\FlattenException`
* deprecated `Symfony\Component\HttpKernel\Kernel::init()``
Expand All @@ -21,7 +22,7 @@ CHANGELOG
* added ControllerReference to create reference of Controllers (used in the FragmentRenderer class)
* [BC BREAK] renamed TimeDataCollector::getTotalTime() to
TimeDataCollector::getDuration()
* updated the MemoryDataCollector to include the memory used in the
* updated the MemoryDataCollector to include the memory used in the
kernel.terminate event listeners
* moved the Stopwatch classes to a new component
* added TraceableControllerResolver
Expand Down
2 changes: 1 addition & 1 deletion src/Symfony/Component/HttpKernel/EventListener/ErrorsLoggerListener.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ public function __construct($channel, LoggerInterface $logger = null)
public function injectLogger()
{
if (null !== $this->logger) {
ErrorHandler::setLogger($this->channel, $this->logger);
ErrorHandler::setLogger($this->logger, $this->channel);
}
}

Expand Down
0