[BC Break][Debug] #2042 implementation of fatal error logging #6474

Koc · 2012-12-23T21:24:36Z

Q	A
Bug fix?	no
New feature?	yes
BC breaks?	yes
Deprecations?	no
Tests pass?	yes
Fixed tickets	#2042
License	MIT
Doc PR	-

Koc · 2012-12-23T21:27:38Z

src/Symfony/Component/HttpKernel/Kernel.php

@@ -96,12 +96,12 @@ public function __construct($environment, $debug)
    public function init()
    {
        ini_set('display_errors', 0);
+        ErrorHandler::register($this->errorReportingLevel);


How better disable rendering of error screens but enable it logging? I can add debug argument to the ErrorHandler::register().

Koc · 2013-04-11T21:17:55Z

In the context of Code Sprint for Symfony 2.3 I have adopted my PR to recent changes (debug extracted into separate component).

Log example:

[2013-04-11 23:47:37] event.DEBUG: Notified event "kernel.controller" to listener "Symfony\Component\HttpKernel\DataCollector\RequestDataCollector::onKernelController". [] []
[2013-04-11 23:47:37] app.EMERGENCY: Call to undefined function Acme\DemoBundle\Controller\aa() {"type":1,"file":"Z:\\home\\dev\\sf2\\src\\Acme\\DemoBundle\\Controller\\WelcomeController.php","line":11} []

Not solved problem: under prod env with disabled debug this errors not logged. But should as this is the goal of #2042

/cc @stof @fabpot

stof · 2013-04-11T21:40:09Z

src/Symfony/Component/HttpKernel/EventListener/ErrorsLoggerListener.php

 */
-class DeprecationLoggerListener implements EventSubscriberInterface
+class ErrorsLoggerListener implements EventSubscriberInterface


Renaming the class is a BC break

and changing its constructor is also a BC break

This class not tagged with @api, but I can revert renaming if needed. But this is inconsistent inject emergency logger via deprecation event listener.

Renaming this class is ok for me as this is not a widely used class anyway (and it was added recently).

fabpot · 2013-04-25T20:41:53Z

src/Symfony/Bundle/FrameworkBundle/Resources/config/debug.xml

+
+        <service id="debug.emergency_logger_listener" class="%debug.errors_logger_listener.class%">
+            <tag name="kernel.event_subscriber" />
+<!--            <tag name="monolog.logger" channel="emergency" />-->


why is commented?

Previously I got an error when uncomment this line. Don't know why, but now it works.

Koc · 2013-04-25T21:35:07Z

I've minimized and documented BC breaks. But to be clear I want to say that this PR was opened before 2.2.x goes to beta state. So it shouldn't be any BC breaks earlier.

Also now we can log fatal errors event in production env.

# app.php
use Symfony\Component\Debug\Debug;

$loader = require_once __DIR__.'/../app/bootstrap.php.cache';
Debug::enable(null, false);

And now log contains:

[2013-04-26 00:22:18] request.ERROR: Uncaught PHP Exception Symfony\Component\HttpKernel\Exception\NotFoundHttpException: "No route found for "GET /"" at Z:\home\dev\sf2\vendor\symfony\symfony\src\Symfony\Component\HttpKernel\EventListener\RouterListener.php line 114 [] []
[2013-04-26 00:22:19] app.EMERGENCY: Call to undefined function aa() {"type":1,"file":"Z:\\home\\dev\\sf2\\web\\app.php","line":27} []

Koc · 2013-04-25T21:40:22Z

Last commit breaks the tests, I know

Koc · 2013-04-25T21:45:50Z

src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php

@@ -48,15 +48,17 @@ public function load(array $configs, ContainerBuilder $container)
        // will be used and everything will still work as expected.
        $loader->load('translation.xml');

-        if ($container->getParameter('kernel.debug')) {
-            $loader->load('debug.xml');
+        $loader->load('debug.xml');


@fabpot Please suggest how can I enable listener that located in this file excluding loading all the file? Add debug_prod.xml?

Splitting the file in two makes sense.

Koc · 2013-04-25T21:57:18Z

tests pass

Koc · 2013-04-26T08:25:44Z

src/Symfony/Component/Debug/ErrorHandler.php

            }

            return true;
        }

-        if (error_reporting() & $level && $this->level & $level) {
+        //TODO: log errors here


@fabpot Does warnings/notices also should be logged in prod env?

Probably not. Fatal errors only.

@fabpot I've removed this TODO. The PR is done

fabpot · 2013-04-30T16:35:42Z

src/Symfony/Component/Debug/Debug.php

@@ -31,8 +31,9 @@ class Debug
     * class loader is also registered.
     *
     * @param integer $errorReportingLevel The level of error reporting you want
+     * @param Boolean $displayErrors Display errors (for dev environment) or just log they (production usage)


typo: log them

This PR was merged into the master branch. Discussion ---------- [Debug] tweak for #6474 This keeps the previous behavior as described in the comment. Commits ------- 7d67b5b [Debug] tweak for #6474

bamarni · 2013-05-01T17:21:42Z

src/Symfony/Component/Debug/Debug.php

        if ('cli' !== php_sapi_name()) {
            ExceptionHandler::register();
-        } elseif (!ini_get('log_errors') || ini_get('error_log')) {
+        } elseif (!ini_get('log_errors') || ini_get('error_log') && $displayErrors) {


I think it's not correct as && takes precedence over ||, see #7895

Koc reviewed Dec 23, 2012
View reviewed changes

symfony#2042 fatal error logging under when debug enabled

1bb5677

stof reviewed Apr 11, 2013
View reviewed changes

xaben mentioned this pull request Apr 12, 2013

[2.2][HttpKernel] ErrorHandler suppresses E_NOTICE error ending up with blank page in dev. #7499

Closed

minimize and document BC breaks

a5e38d4

fabpot reviewed Apr 25, 2013
View reviewed changes

Koc reviewed Apr 25, 2013
View reviewed changes

Koc reviewed Apr 26, 2013
View reviewed changes

fatal errors logging in production environment symfony#2042

6ca1339

fabpot reviewed Apr 30, 2013
View reviewed changes

fabpot closed this in 9d5f10c Apr 30, 2013

fabpot added a commit that referenced this pull request Apr 30, 2013

tweaked previous merge (refs #6474)

4dcee0a

bamarni added a commit to bamarni/symfony that referenced this pull request May 1, 2013

[Debug] tweak for symfony#6474

7d67b5b

bamarni reviewed May 1, 2013
View reviewed changes

fabpot mentioned this pull request Jun 13, 2013

Improving Error Handler when debug is false. #7777

Closed

Koc referenced this pull request in symfony/symfony-standard Jun 14, 2013

udpated the CHANGELOG for 2.3

e4806c3

Koc deleted the fatal-errors-logging branch March 12, 2014 23:15

fabpot mentioned this pull request Sep 24 6932 , 2014

Missing prod debug handler #11053

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

[BC Break][Debug] #2042 implementation of fatal error logging #6474

[BC Break][Debug] #2042 implementation of fatal error logging #6474

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

[BC Break][Debug] #2042 implementation of fatal error logging #6474

[BC Break][Debug] #2042 implementation of fatal error logging #6474

Uh oh!

Conversation

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!