[FEATURE] Added tests to new __call method in property path

symfony · piotrpasich · Dec 19, 2012 · Dec 19, 2012 · Dec 19, 2012 · Dec 19, 2012
commit ad215c503954b50c886f37e2b6743bbbc2e7e54b
diff --git a/src/Symfony/Component/Form/Tests/Fixtures/Magician.php b/src/Symfony/Component/Form/Tests/Fixtures/Magician.php
@@ -25,20 +25,4 @@ public function __get($property)
         return isset($this->$property) ? $this->$property : null;
     }
 
-    public function __call($methodName, $args)
-    {
-        $returnValue = null;
-        $property = lcfirst(substr($methodName, 3));
-
-        switch (substr($methodName, 0, 3)) {
-            case 'get':
-                $returnValue = $this->__get($property);
-                break;
-            case 'set':
-                $returnValue = $this->__set($property, $args);
-                break;
-        }
-
-        return $returnValue;
-    }
 }
diff --git a/src/Symfony/Component/Form/Tests/Fixtures/MagicianCall.php b/src/Symfony/Component/Form/Tests/Fixtures/MagicianCall.php
@@ -0,0 +1,45 @@
+<?php
+
+/*
+ * This file is part of the Symfony package.
+ *
+ * (c) Piotr Pasich <piotr.pasich@xsolve.pl>
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ */
+
+namespace Symfony\Component\Form\Tests\Fixtures;
+
+class MagicianCall
+{
+    private $foobar;
+
+    public function __call($methodName, $args)
+    {
+        $returnValue = null;
+        $property = lcfirst(substr($methodName, 3));
+
+        switch (substr($methodName, 0, 3)) {
+            case 'get':
+                $returnValue = $this->get($property);
+                break;
+            case 'set':
+                $returnValue = $this->set($property, $args);
+                break;
+        }
+
+        return $returnValue;
+    }
+
+    private function set($property, $value)
+    {
+        $this->$property = $value;
+    }
+
+    private function get($property)
+    {
+        return isset($this->$property) ? $this->$property : null;
+    }
+
+}
diff --git a/src/Symfony/Component/Form/Tests/Util/PropertyPathTest.php b/src/Symfony/Component/Form/Tests/Util/PropertyPathTest.php
@@ -14,6 +14,7 @@
 use Symfony\Component\Form\Util\PropertyPath;
 use Symfony\Component\Form\Tests\Fixtures\Author;
 use Symfony\Component\Form\Tests\Fixtures\Magician;
+use Symfony\Component\Form\Tests\Fixtures\MagicianCall;
 
 class PropertyPathTest extends \PHPUnit_Framework_TestCase
 {
@@ -322,9 +323,10 @@ public function testSetValueUpdateMagicSet()
 
     public function testSetValueUpdateMagicCall()
     {
-        $object = new Magician();
+        $object = new MagicianCall();
 
-        $object->setMagicProperty('foobar');
+        $path = new PropertyPath('magicProperty');
+        $path->setValue($object, 'foobar');
 
         $this->assertEquals('foobar', $object->getMagicProperty());
     }